Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x11-drivers/xf86-video-amdgpu: Adds postinst elog to fix #778494 #20151

Closed
wants to merge 1 commit into from
Closed

x11-drivers/xf86-video-amdgpu: Adds postinst elog to fix #778494 #20151

wants to merge 1 commit into from

Conversation

pinkflames
Copy link
Contributor

Due to EAPI=7 changes described in #661502 , the amdgpu DDX does not
work out of the box. This commit introduces an elog message
detailing the workaround that AMDGPU users on Gentoo need to apply
manually to get a working Xorg server.

Closes: https://bugs.gentoo.org/778494
Signed-off-by: Niklāvs Koļesņikovs 89q1r14hd@relay.firefox.com

Also updated the ebuild header with the current year, of course.

Due to EAPI=7 changes described in #661502 , the amdgpu DDX does not
work out of the box. This commit introduces an elog message
detailing the workaround that AMDGPU users on Gentoo need to apply
manually to get a working Xorg server.

Closes: https://bugs.gentoo.org/778494
Signed-off-by: Niklāvs Koļesņikovs <89q1r14hd@relay.firefox.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @pinkflames
Areas affected: ebuilds
Packages affected: x11-drivers/xf86-video-amdgpu

x11-drivers/xf86-video-amdgpu: @gentoo/x11

Linked bugs

Bugs linked: 778494


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 27, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-03-27 19:24 UTC
Newest commit scanned: 60f4439
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a247231dc5/output.html

@mattst88
Copy link
Contributor

Due to EAPI=7 changes described in #661502 , the amdgpu DDX does not
work out of the box.

The changes noted in that bug were reverted. Specifically, the problem was that xf86-video-amdgpu didn't inherit xorg-3, which does this:

      [[ ${PN} == xorg-server || ${PN} == xf86-video-* || ${PN} == xf86-input-* ]] \
          && append-ldflags -Wl,-z,lazy

But today it inherits xorg-3. So this cannot be the problem I don't believe.

@pinkflames
Copy link
Contributor Author

pinkflames commented Mar 27, 2021

Thanks for the explanation, that old bug report was a bit over my head. Should I keep this PR open to potentially update it?

@mattst88
Copy link
Contributor

Yeah, leaving it open until we figure out what's going on with the reporter's system seems fine to me.

Thanks!

@mattst88
Copy link
Contributor

Looks like -fno-plt is the problem.

@mattst88 mattst88 closed this Mar 27, 2021
@ionenwks
Copy link
Contributor

Looks like -fno-plt is the problem.

Yeah, -fno-plt makes lazy bindings non-functional and we know how that goes with xorg.

@pinkflames pinkflames deleted the amdgpu-workaround branch March 28, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
5 participants