xorg-3.eclass: strip -fno-plt from *FLAGS #20166
Conversation
Pull Request assignmentSubmitter: @pinkflames @gentoo/github Linked bugsBugs linked: 778494 New packagesThis Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
need assignment
Pull request CI reportReport generated at: 2021-03-28 21:34 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
I have reformated the patch to match the style of the one posted to the gentoo-dev ML, updated the associated comment and rebased on the new xorg-3.eclass in Portage. I also want to point out that this PR contains a second commit that changes WANT_AUTO* variable placement that I have not received any kind of feedback on. |
Pull request CI reportReport generated at: 2021-03-31 12:24 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2021-04-06 22:59 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
As discussed in #778494, the GCC flag -fno-plt will break lazy binding, which appears to still be necessary for Xorg. Stripping the offending flag out is the next best solution for reliable user experience on Gentoo. Closes: https://bugs.gentoo.org/778494 Signed-off-by: Niklāvs Koļesņikovs <89q1r14hd@relay.firefox.com>
Fixes compatibility with the updated autotools.eclass. Signed-off-by: Niklāvs Koļesņikovs <89q1r14hd@relay.firefox.com>
Pull request CI reportReport generated at: 2021-05-02 14:34 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
As discussed in #778494, the GCC flag -fno-plt will break lazy
binding, which appears to still be necessary for Xorg. Stripping the
offending flag out is the next best solution for reliable user
experience on Gentoo.
Closes: https://bugs.gentoo.org/778494
Signed-off-by: Niklāvs Koļesņikovs 89q1r14hd@relay.firefox.com
I first tried to remove lazy binding but it was still producing broken Xorg drivers, so I then tried stripping out -fno-plt and that worked. I also checked that no other eclass (apart from the now unused xorg-2) is using z,lazy and may have needed the same fix.
Oh, and credit/thanks go to @AdelKS for discovering and reporting this to the Gentoo bug tracker and @mattst88 for correctly identifying the cause and describing how to fix it.