net-misc/bird: New upstream version 2.0.8 #20196
Conversation
Pull Request assignmentSubmitter: @alarig acct-group/bird: @gentoo/proxy-maint (new package) At least one of the listed packages is maintained entirely by non-GitHub developers! Linked bugsBugs linked: 779328 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
new package
| <maintainer type="person"> | ||
| <email>alarig@swordarmor.fr</email> | ||
| <name>Alarig Le Lay</name> | ||
| </maintainer> |
There was a problem hiding this comment.
In every metadata.xml, under your you have to add also proxy-maintainer https://dpaste.com/5TXHKMW7G
There was a problem hiding this comment.
Yeah, I realised it afterward with the qa web report, I just added proxy-maintainer
acct-user/bird/bird-0.ebuild
Outdated
|
|
||
| inherit acct-user | ||
|
|
||
| KEYWORDS="amd64 arm64 x86" |
There was a problem hiding this comment.
acct-user and acct-group does not need KEYWORDS, so drop them completely
There was a problem hiding this comment.
yeah, the eclass sets them to everything, so this is actually reducing the keywords
There was a problem hiding this comment.
I didn’t know that, thanks for the tip!
net-misc/bird/bird-2.0.8.ebuild
Outdated
| libssh? ( net-libs/libssh:= )" | ||
| BDEPEND="sys-devel/flex | ||
| sys-devel/bison | ||
| sys-devel/m4" |
| acct-group/bird | ||
| acct-user/bird | ||
| ) | ||
| libssh? ( net-libs/libssh:= )" |
There was a problem hiding this comment.
As you haven't added a :slot=, you can simply use net-libs/libssh
There was a problem hiding this comment.
:= allows you to be rebuilt when the subslot changes, libssh exposes a subslot ("SLOT="0/4" # subslot = soname major version") and we want to be rebuilt when its ABI changes. So this is fine as-is
| FILECAPS=( | ||
| CAP_NET_ADMIN usr/sbin/bird | ||
| CAP_NET_BIND_SERVICE usr/sbin/bird | ||
| CAP_NET_RAW usr/sbin/bird | ||
| ) |
There was a problem hiding this comment.
If you’re speaking about the indentation, it’s because it’s displayed with narrower tabs in vim, so for github it has too much spaces
Package-Manager: Portage-3.0.17, Repoman-3.0.2 Signed-off-by: Alarig Le Lay <alarig@swordarmor.fr>
Package-Manager: Portage-3.0.17, Repoman-3.0.2 Signed-off-by: Alarig Le Lay <alarig@swordarmor.fr>
Closes: https://bugs.gentoo.org/779328 Package-Manager: Portage-3.0.17, Repoman-3.0.2 Signed-off-by: Alarig Le Lay <alarig@swordarmor.fr>
This commits should be better, don’t hesitate if I’ve missed something :) |
You’re welcome :) |
Pull request CI reportReport generated at: 2021-04-02 15:10 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2021-04-02 15:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Thanks! |
No description provided.