app-editors/nvi: various fixes #2031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| epatch "${FILESDIR}"/${P}-perl-shortnames.patch | ||
| epatch "${FILESDIR}"/${P}-ac_config_header.patch | ||
| epatch "${FILESDIR}"/${P}-use_pkgconfig_for_ncurses.patch | ||
| eapply "${FILESDIR}"/${P}-strlen-macro-renaming.patch |
There was a problem hiding this comment.
don't use bajillions of eapply's, just drop them into a bash array called PATCHES and then call default instead of eapply + eapply_user
|
Thanks for the review! |
|
😞 The QA check for this pull request has found the following issues: Issues inherited from Gentoo (may be modified by PR): |
| popd 2>/dev/null | ||
| pushd dist 2>/dev/null || die | ||
| default | ||
| popd 2>/dev/null || die |
There was a problem hiding this comment.
emake -C dist
would be actually better.
mgorny
added
version bump
assigned
|
@gentoo/proxy-maint |
* add myself as proxied maintainer * bump EAPI to 6 and clean up ebuild * add patch from https://bugs.gentoo.org/508922 * add patch to fix parallel make install
|
😞 The QA check for this pull request has found the following issues: Issues inherited from Gentoo (may be modified by PR): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@proxy-maint