Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-tex/biber: disable 64-bit only tests on 32-bit arches #20316

Closed
wants to merge 1 commit into from

Conversation

j-licht
Copy link
Contributor

@j-licht j-licht commented Apr 9, 2021

Closes: https://bugs.gentoo.org/780879
Package-Manager: Portage-3.0.17, Repoman-3.0.2
Signed-off-by: Jonas Licht jonas.licht@fem.tu-ilmenau.de

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @j-licht
Areas affected: ebuilds
Packages affected: dev-tex/biber

dev-tex/biber: jonas.licht[at]gmail.com, @gentoo/proxy-maint

Linked bugs

Bugs linked: 780879


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 9, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-04-09 20:09 UTC
Newest commit scanned: d824acd
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/33511f8a23/output.html


src_prepare() {
#disable 64-bit only Tests on non 64-bit archs
use amd64 || use arm64 || eapply "${FILESDIR}/${P}-disable-64bit-only-tests.patch"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's a cleaner way to do this (detect it), but hey, works for now.

-eq_or_diff($out->get_output_entry('era2', $main), $era2, 'Date meta information - 2');
-eq_or_diff($out->get_output_entry('era3', $main), $era3, 'Date meta information - 3');
-eq_or_diff($out->get_output_entry('era4', $main), $era4, 'Date meta information - 4');
+#eq_or_diff($out->get_output_entry('era1', $main), $era1, 'Date meta information - 1');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually don't commit patches with comments, we just remove the lines. The patch shows us which lines have been removed so information is lost. I need to update this accordingly

Closes: https://bugs.gentoo.org/780879
Package-Manager: Portage-3.0.17, Repoman-3.0.2
Signed-off-by: Jonas Licht <jonas.licht@fem.tu-ilmenau.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-04-09 23:14 UTC
Newest commit scanned: 77c6fb6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b85150b7ba/output.html

@thesamesam
Copy link
Member

Thanks! (And thanks for responding to feedback so quickly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants