dev-php/pecl-parallel: New package: v1.1.4 #20348

jkroonza · 2021-04-12T13:29:04Z

Package-Manager: Portage-3.0.17, Repoman-3.0.2
Signed-off-by: Jaco Kroon jaco@uls.co.za

gentoo-bot · 2021-04-12T13:32:06Z

Pull Request assignment

Submitter: @jkroonza
Areas affected: ebuilds
Packages affected: dev-php/pecl-parallel

dev-php/pecl-parallel: @gentoo/proxy-maint (new package)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2021-04-12T13:40:14Z

Pull request CI report

Report generated at: 2021-04-12 13:40 UTC
Newest commit scanned: 21f1905
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/815a3c27e4/output.html

juippis · 2021-04-14T06:12:55Z

dev-php/pecl-parallel/Manifest

@@ -0,0 +1 @@
+DIST parallel-1.1.4.tgz 58783 BLAKE2B 942c767ff4838c13e70829d6ac6599cee3185afaf71e9dc430064835102d31a3e50b99694e1632be652c6a019934a13ba0f5139041bba39d486a20615478b910 SHA512 6693f01b0d43de5153aa0953f90580717e519cfbe8ca5b0ba6abd9cc681e0efe9d7c6fcc601da98f74b570b5810dffdbf5100bedc8ab86c1f4bc61d48955ae77


Is there an easy way to rename this as ${PN}? I'd really prefer that. Rest looks good, as always...

I can see why ... doesn't look like there is a simple way no, this is as per the php-ext-pecl-r3 eclass.

So fortunately it doesn't look like there are any probable collisions in the tree (dev-ruby/parallel uses .tar.gz not .tgz and sys-process/parallel uses .tar.bz2). Confusing yes ...

Perhaps we should consider updating the eclass to rename on download?

51 if [[ -z "${PHP_EXT_PECL_FILENAME}" ]] ; then 52 SRC_URI="https://pecl.php.net/get/${PHP_EXT_PECL_PKG_V}.tgz" 53 else 54 SRC_URI="https://pecl.php.net/get/${PHP_EXT_PECL_FILENAME}" 55 fi

-> ${P}.tgz and -> ${P}.${PHP_EXT_PECL_FILENAME##*.} respectively? Although, the latter would need more care for double extensions such as .tar.${comp}

Alternatively a PHP_EXT_PECL_DOWNLOADED_FILENAME which if not set we default to ${P}.tgz if PHP_EXT_PECL_FILENAME is not set, or ${P}.${detected_ext} ... where detected_ext is tar.${PHP_EXT_PECL_FILENAME##*.} or simply ${PHP_EXT_PECL_FILENAME##*.} ... but this gets nasty no matter how you look at it.

dev-php/pecl-parallel/pecl-parallel-1.1.4.ebuild

gentoo-repo-qa-bot · 2021-04-14T09:40:17Z

Pull request CI report

Report generated at: 2021-04-14 09:40 UTC
Newest commit scanned: 69474e3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f6d12a7d5e/output.html

gentoo-repo-qa-bot · 2021-04-14T10:40:19Z

Pull request CI report

Report generated at: 2021-04-14 10:40 UTC
Newest commit scanned: 7408894
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/18d3dd1f1c/output.html

juippis

This won't compile for me with +php_targets_php8-0, could you try?

[ERROR] >>> Not all runs were successful.
atom: =dev-php/pecl-parallel-1.1.4, USE flags: 'php_targets_php7-3 php_targets_php7-4 php_targets_php8-0'
atom: =dev-php/pecl-parallel-1.1.4, USE flags: '-php_targets_php7-3 php_targets_php7-4 php_targets_php8-0'
atom: =dev-php/pecl-parallel-1.1.4, USE flags: 'php_targets_php7-3 -php_targets_php7-4 php_targets_php8-0'
atom: =dev-php/pecl-parallel-1.1.4, USE flags: '-php_targets_php7-3 -php_targets_php7-4 php_targets_php8-0'

/var/tmp/portage/dev-php/pecl-parallel-1.1.4/work/php8.0/src/channel.c:386:34: error: 'zend_object_handlers' {aka 'struct _zend_object_handlers'} has no member named 'compare_objects'
  386 |     php_parallel_channel_handlers.compare_objects = php_parallel_channel_compare;
      |                                  ^
/var/tmp/portage/dev-php/pecl-parallel-1.1.4/work/php8.0/src/check.c:129:85: warning: implicit declaration of function 'ZEND_TYPE_IS_CLASS'; did you mean 'ZEND_TYPE_HAS_CLASS'? [-Wimplicit-function-declaration[https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration]]
  129 |     if (ZEND_TYPE_IS_SET(it->type) && (ZEND_TYPE_CODE(it->type) == IS_OBJECT || ZEND_TYPE_IS_CLASS(it->type))) {
      |                                                                                 ^~~~~~~~~~~~~~~~~~
      |                                                                                 ZEND_TYPE_HAS_CLASS
/var/tmp/portage/dev-php/pecl-parallel-1.1.4/work/php8.0/src/check.c:139:15: error: 'zend_arg_info' {aka 'struct _zend_arg_info'} has no member named 'pass_by_reference'
  139 |         if (it->pass_by_reference) {
      |               ^~
/var/tmp/portage/dev-php/pecl-parallel-1.1.4/work/php8.0/src/check.c:165:15: error: 'zend_arg_info' {aka 'struct _zend_arg_info'} has no member named 'pass_by_reference'
  165 |         if (it->pass_by_reference) {
      |               ^~
/var/tmp/portage/dev-php/pecl-parallel-1.1.4/work/php8.0/src/cache.c:276:30: warning: implicit declaration of function 'ZEND_TYPE_ENCODE_CLASS'; did you mean 'ZEND_TYPE_INIT_CLASS'? [-Wimplicit-function-declaration[https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration]]
  276 |                 info->type = ZEND_TYPE_ENCODE_CLASS(name, nulls);
      |                              ^~~~~~~~~~~~~~~~~~~~~~
      |                              ZEND_TYPE_INIT_CLASS
/var/tmp/portage/dev-php/pecl-parallel-1.1.4/work/php8.0/src/cache.c:276:30: error: incompatible types when assigning to type 'zend_type' from type 'int'
/var/tmp/portage/dev-php/pecl-parallel-1.1.4/work/php8.0/src/check.c: In function 'php_parallel_check_class_inline':
/var/tmp/portage/dev-php/pecl-parallel-1.1.4/work/php8.0/src/check.c:538:13: warning: implicit declaration of function 'ZEND_TYPE_IS_CE'; did you mean 'ZEND_TYPE_IS_SET'? [-Wimplicit-function-declaration[https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration]]
  538 |         if (ZEND_TYPE_IS_CE(info->type)) {
      |             ^~~~~~~~~~~~~~~
      |             ZEND_TYPE_IS_SET
make: *** [Makefile:230: src/channel.lo] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Makefile:228: src/cache.lo] Error 1
make: *** [Makefile:224: src/check.lo] Error 1
 * ERROR: dev-php/pecl-parallel-1.1.4::gentoo failed (compile phase):
 *   emake failed

juippis · 2021-04-14T11:51:32Z

dev-php/pecl-parallel/pecl-parallel-1.1.4.ebuild

+
+inherit php-ext-pecl-r3
+
+SRC_URI="${SRC_URI} -> ${P}.tgz"


Not exactly what I had in mind, but hey, if it works it's fine.

(I'd just replicated the eclass line,
SRC_URI="https://pecl.php.net/get/${PHP_EXT_NAME}-${PV/_/}.tgz"

Your call. Or perhaps at least a comment above:

# php-ext-pecl will set SRC_URI to the download URI, so just rename

Package-Manager: Portage-3.0.17, Repoman-3.0.2 Signed-off-by: Jaco Kroon <jaco@uls.co.za>

gentoo-repo-qa-bot · 2021-04-14T12:20:07Z

Pull request CI report

Report generated at: 2021-04-14 12:20 UTC
Newest commit scanned: 5c08fd3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8ae087b76c/output.html

juippis · 2021-04-28T13:53:12Z

dev-php/pecl-parallel/pecl-parallel-1.1.4.ebuild

+
+inherit php-ext-pecl-r3
+
+SRC_URI="${SRC_URI} -> ${P}.tgz"


Yeah let's replicate the eclass URL here.

I doubt the eclass will ever drop or modify that URL, but just in case it does...

juippis · 2021-04-28T14:06:51Z

^ well my intention was to do ${PN}-${PV/_/}.tgz and not pecl-${PHP_EXT_NAME}-${PV/_/}.tgz, please update the cosmetic issue when you next touch this package (php-8, vbump, etc) :)

gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Apr 12, 2021

juippis reviewed Apr 14, 2021

View reviewed changes

jkroonza force-pushed the pecl-parallel branch from 21f1905 to 69474e3 Compare April 14, 2021 09:28

jkroonza force-pushed the pecl-parallel branch from 69474e3 to 7408894 Compare April 14, 2021 10:26

juippis reviewed Apr 14, 2021

View reviewed changes

dev-php/pecl-parallel: New package: v1.1.4

5c08fd3

Package-Manager: Portage-3.0.17, Repoman-3.0.2 Signed-off-by: Jaco Kroon <jaco@uls.co.za>

jkroonza force-pushed the pecl-parallel branch from 7408894 to 5c08fd3 Compare April 14, 2021 12:07

juippis approved these changes Apr 28, 2021

View reviewed changes

gentoo-bot closed this in 45af1b1 Apr 28, 2021

jkroonza deleted the pecl-parallel branch May 6, 2021 19:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dev-php/pecl-parallel: New package: v1.1.4 #20348

dev-php/pecl-parallel: New package: v1.1.4 #20348

jkroonza commented Apr 12, 2021

gentoo-bot commented Apr 12, 2021

gentoo-repo-qa-bot commented Apr 12, 2021

juippis Apr 14, 2021

jkroonza Apr 14, 2021 •

edited

gentoo-repo-qa-bot commented Apr 14, 2021

gentoo-repo-qa-bot commented Apr 14, 2021

juippis left a comment

juippis Apr 14, 2021

jkroonza Apr 14, 2021

gentoo-repo-qa-bot commented Apr 14, 2021

juippis Apr 28, 2021

juippis commented Apr 28, 2021

		@@ -0,0 +1 @@
		DIST parallel-1.1.4.tgz 58783 BLAKE2B 942c767ff4838c13e70829d6ac6599cee3185afaf71e9dc430064835102d31a3e50b99694e1632be652c6a019934a13ba0f5139041bba39d486a20615478b910 SHA512 6693f01b0d43de5153aa0953f90580717e519cfbe8ca5b0ba6abd9cc681e0efe9d7c6fcc601da98f74b570b5810dffdbf5100bedc8ab86c1f4bc61d48955ae77


		inherit php-ext-pecl-r3

		SRC_URI="${SRC_URI} -> ${P}.tgz"


		inherit php-ext-pecl-r3

		SRC_URI="${SRC_URI} -> ${P}.tgz"

dev-php/pecl-parallel: New package: v1.1.4 #20348

dev-php/pecl-parallel: New package: v1.1.4 #20348

Conversation

jkroonza commented Apr 12, 2021

gentoo-bot commented Apr 12, 2021

Pull Request assignment

Linked bugs

New packages

gentoo-repo-qa-bot commented Apr 12, 2021

Pull request CI report

juippis Apr 14, 2021

Choose a reason for hiding this comment

jkroonza Apr 14, 2021 • edited

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Apr 14, 2021

Pull request CI report

gentoo-repo-qa-bot commented Apr 14, 2021

Pull request CI report

juippis left a comment

Choose a reason for hiding this comment

juippis Apr 14, 2021

Choose a reason for hiding this comment

jkroonza Apr 14, 2021

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Apr 14, 2021

Pull request CI report

juippis Apr 28, 2021

Choose a reason for hiding this comment

juippis commented Apr 28, 2021

jkroonza Apr 14, 2021 •

edited