New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net-im/qtox: Added qtox version 1.17.3 #20357
Conversation
Pull Request assignmentSubmitter: @rollagnier net-im/qtox: @gentoo/proxy-maint (maintainer needed) Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. Missing GCO sign-offPlease read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2021-04-12 22:04 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good! But we still require the Signed-off-by:
line with your real name present,
https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin
Check any commit to ::gentoo as an example,
7ccdbea (randomly picked newest commit). It has two signed-off-by lines, one from the author and one from the committer. We need yours before this can be merged.
Now you can amend your commit, or just comment the signed-off-by line here in Github, and I'll add it to you while merging.
In future, you can automate adding the signed-off-by line by adding SIGNED_OFF_BY="My Name <my@e.mail>"
in your make.conf while using repoman to commit, or by using pkgdev commit too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Rémi Ollagnier remi.ollagnier@free.fr
Signed-off-by: Rémi Ollagnier <remi.ollagnier@free.fr> Package-Manager: Portage-3.0.13, Repoman-3.0.2
Pull request CI reportReport generated at: 2021-04-14 20:14 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
||
DESCRIPTION="qTox is an instant messaging client using the encrypted p2p Tox protocol" | ||
HOMEPAGE="https://qtox.github.io/" | ||
SRC_URI="https://github.com/qTox/qTox/archive/v${PV}.tar.gz -> ${MY_P}.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to update this to point out to proper release download link,
https://github.com/qTox/qTox/releases/tag/v1.17.3
Other than that, works perfectly, thanks!
Package-Manager: Portage-3.0.13, Repoman-3.0.2