Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-im/qtox: Added qtox version 1.17.3 #20357

Closed
wants to merge 1 commit into from

Conversation

rollagnier
Copy link

Package-Manager: Portage-3.0.13, Repoman-3.0.2

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @rollagnier
Areas affected: ebuilds
Packages affected: net-im/qtox

net-im/qtox: @gentoo/proxy-maint (maintainer needed)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Apr 12, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-04-12 22:04 UTC
Newest commit scanned: c420fbe
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/af02af7b0e/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! But we still require the Signed-off-by: line with your real name present,
https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin

Check any commit to ::gentoo as an example,
7ccdbea (randomly picked newest commit). It has two signed-off-by lines, one from the author and one from the committer. We need yours before this can be merged.

Now you can amend your commit, or just comment the signed-off-by line here in Github, and I'll add it to you while merging.

In future, you can automate adding the signed-off-by line by adding SIGNED_OFF_BY="My Name <my@e.mail>" in your make.conf while using repoman to commit, or by using pkgdev commit too.

Copy link
Author

@rollagnier rollagnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Rémi Ollagnier remi.ollagnier@free.fr

Signed-off-by: Rémi Ollagnier <remi.ollagnier@free.fr>

Package-Manager: Portage-3.0.13, Repoman-3.0.2
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-04-14 20:14 UTC
Newest commit scanned: 88f25b0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ec69c03788/output.html


DESCRIPTION="qTox is an instant messaging client using the encrypted p2p Tox protocol"
HOMEPAGE="https://qtox.github.io/"
SRC_URI="https://github.com/qTox/qTox/archive/v${PV}.tar.gz -> ${MY_P}.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to update this to point out to proper release download link,
https://github.com/qTox/qTox/releases/tag/v1.17.3

Other than that, works perfectly, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
4 participants