Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

www-apps/kibana-bin: restrict nodejs version #20365

Closed
wants to merge 1 commit into from
Closed

www-apps/kibana-bin: restrict nodejs version #20365

wants to merge 1 commit into from

Conversation

hydrapolic
Copy link
Contributor

Closes: https://bugs.gentoo.org/782376
Signed-off-by: Tomáš Mózes hydrapolic@gmail.com

@hydrapolic
www-apps/kibana-bin: restrict nodejs version
a302b5e 
Closes: https://bugs.gentoo.org/782376
Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @hydrapolic
Areas affected: ebuilds
Packages affected: www-apps/kibana-bin

www-apps/kibana-bin: @hydrapolic, @ferki, @gentoo/proxy-maint

Linked bugs

Bugs linked: 782376

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 13, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-04-13 13:39 UTC
Newest commit scanned: a302b5e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/60c279251d/output.html

juippis
juippis approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if a simple sed/patch to modify the restriction actually works... I hope upstream is aware and working on this.

@hydrapolic
Copy link
Contributor Author

That probably won't be that easy, just by checking the error message the user reported:

Error: The module '/opt/kibana/node_modules/re2/build/Release/re2.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 83. This version of Node.js requires
NODE_MODULE_VERSION 88. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).

Thanks for the review/merge @juippis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@hydrapolic @gentoo-bot @gentoo-repo-qa-bot @juippis