New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net-mail/automx2: Bump to version 2021.4 #20477
Conversation
Upstream bugfix release. Package-Manager: Portage-3.0.17, Repoman-3.0.2 Signed-off-by: Ralph Seichter <gentoo@seichter.de>
Pull Request assignmentSubmitter: @rseichter net-mail/automx2: @rseichter, @mschiff Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2021-04-20 19:59 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
@thesamesam Pinging you because mschiff is currently circumnavigating the globe (AFAIK) and because you have processed pull requests for automx2 in the past. |
@thesamesam Polite bump. This PR has now been open since mid-April. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits / points to think about, but this works for me. Sorry it took a while after your ping.
DOCS="*.adoc doc/*.adoc contrib/*sample.conf" | ||
HTML_DOCS="doc/*.html doc/*.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should prefix these with local
and transform to an array form, or use dodoc here respectively.
DOCS="*.adoc doc/*.adoc contrib/*sample.conf" | ||
HTML_DOCS="doc/*.html doc/*.svg" | ||
fi | ||
sed -e "s/@EPYTHON@/${EPYTHON}/" "${FILESDIR}/init" | newinitd - "${PN}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could also be reworked and made sure sed
call doesn't fail with || die
. But... with distutils, I think having EPYTHON="python"
fits more to the eclass spirit. The default interpreter is then selected via eselect python
. Or you could use DISTUTILS_SINGLE_IMPL
.
LICENSE="GPL-3+" | ||
SLOT="0" | ||
KEYWORDS="~amd64" | ||
IUSE="doc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it doesn't look like anything is required to generate those doc files, how much size do they take after being installed? Maybe this USE flag is redundant and they could be installed unconditionally?
Upstream bugfix release.