Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-mail/automx2: Bump to version 2021.4 #20477

Closed
wants to merge 1 commit into from
Closed

net-mail/automx2: Bump to version 2021.4 #20477

wants to merge 1 commit into from

Conversation

rseichter
Copy link
Contributor

Upstream bugfix release.

Upstream bugfix release.

Package-Manager: Portage-3.0.17, Repoman-3.0.2
Signed-off-by: Ralph Seichter <gentoo@seichter.de>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @rseichter
Areas affected: ebuilds
Packages affected: net-mail/automx2

net-mail/automx2: @rseichter, @mschiff

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Apr 20, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-04-20 19:59 UTC
Newest commit scanned: 698ce27
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/058f2195ec/output.html

@rseichter
Copy link
Contributor Author

@thesamesam Pinging you because mschiff is currently circumnavigating the globe (AFAIK) and because you have processed pull requests for automx2 in the past.

@thesamesam thesamesam self-requested a review May 18, 2021 02:01
@rseichter
Copy link
Contributor Author

@thesamesam Polite bump. This PR has now been open since mid-April.

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits / points to think about, but this works for me. Sorry it took a while after your ping.

Comment on lines +41 to +42
DOCS="*.adoc doc/*.adoc contrib/*sample.conf"
HTML_DOCS="doc/*.html doc/*.svg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should prefix these with local and transform to an array form, or use dodoc here respectively.

DOCS="*.adoc doc/*.adoc contrib/*sample.conf"
HTML_DOCS="doc/*.html doc/*.svg"
fi
sed -e "s/@EPYTHON@/${EPYTHON}/" "${FILESDIR}/init" | newinitd - "${PN}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be reworked and made sure sed call doesn't fail with || die. But... with distutils, I think having EPYTHON="python" fits more to the eclass spirit. The default interpreter is then selected via eselect python. Or you could use DISTUTILS_SINGLE_IMPL.

LICENSE="GPL-3+"
SLOT="0"
KEYWORDS="~amd64"
IUSE="doc"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it doesn't look like anything is required to generate those doc files, how much size do they take after being installed? Maybe this USE flag is redundant and they could be installed unconditionally?

@gentoo-bot gentoo-bot closed this in 26d9b43 Jun 6, 2021
@rseichter rseichter deleted the automx2-0420 branch June 7, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants