dev-java/commons-logging: EAPI 7, java min 1.8

[vaukai]

No description provided.

[gentoo-bot]

Pull Request assignment

Submitter: @vaukai
Areas affected: ebuilds
Packages affected: dev-java/commons-logging

dev-java/commons-logging: @gentoo/java

Linked bugs

Bugs linked: 784767

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2021-04-21 09:59 UTC
Newest commit scanned: 16d230b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3193620704/output.html

[fordfrog]

@vaukai thanks! i also switched to the latest servlet api in 679c816

[vaukai]

Sorry, forgot to mention ... (happens with java 11)

 * Complete command:
 * java-pkg_dojar /var/tmp/portage/dev-java/commons-logging-1.2-r3/temp/commons-logging-api.jar
Good: 1.8 /var/tmp/portage/dev-java/commons-logging-1.2-r3/temp/commons-logging-adapters.jar org/apache/commons/logging/impl/Jdk13LumberjackLogger.class
Good: 1.8 /var/tmp/portage/dev-java/commons-logging-1.2-r3/temp/commons-logging-adapters.jar org/apache/commons/logging/impl/Jdk14Logger.class
Good: 1.8 /var/tmp/portage/dev-java/commons-logging-1.2-r3/temp/commons-logging-adapters.jar org/apache/commons/logging/impl/NoOpLog.class
Good: 1.8 /var/tmp/portage/dev-java/commons-logging-1.2-r3/temp/commons-logging-adapters.jar org/apache/commons/logging/impl/SimpleLog$1.class
Good: 1.8 /var/tmp/portage/dev-java/commons-logging-1.2-r3/temp/commons-logging-adapters.jar org/apache/commons/logging/impl/SimpleLog.class
CVV: 8
Checked: 5 Good: 5 Bad: 0
 * Verbose logging for "java-pkg_dojar" function
 * Jar file(s) destination: /usr/share/commons-logging/lib
 * Jar file(s) created: /var/tmp/portage/dev-java/commons-logging-1.2-r3/temp/commons-logging-adapters.jar
 * Complete command:
 * java-pkg_dojar /var/tmp/portage/dev-java/commons-logging-1.2-r3/temp/commons-logging-adapters.jar
 * No index.html in javadoc directory
 * ERROR: dev-java/commons-logging-1.2-r3::gentoo failed (install phase):
 *   No index.html in javadoc directory

I am getting the impression that's a central problem with the java-ant-2 eclass.
What's needed to fix it, if not moving everything to java-pkg-simple ?

[fordfrog]

i came across this issue too but did not have time to investigate it more. all i found is the fact that though generation of the documentation does not fail, no documentation is generated (the target directory is empty). i also think this is not an issue just of this ebuild but more might be affected.

java-pkg-simple is definitely a better choice for us in many cases (most of them). tweaking and fixing build.xml is not imo the way to go, it gets pretty complex and things might get broken anyway.

we might either investigate where the issue is with ant and javadoc or just move away from it and use java-pkg-simple, which might save us time.