Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-java/codemodel: min java 1.8 #20528

Closed
wants to merge 1 commit into from
Closed

Conversation

vaukai
Copy link
Contributor

@vaukai vaukai commented Apr 24, 2021

Bug: https://bugs.gentoo.org/785415

When doc USE flag is enabled and only then it fails with:

 * Generating JavaDoc ...
./com/sun/codemodel/util/SingleByteEncoder.java:53: error: package sun.nio.cs is not visible
import sun.nio.cs.Surrogate;
              ^
  (package sun.nio.cs is declared in module java.base, which does not export it to the unnamed module)
1 error

Bug: https://bugs.gentoo.org/785415

Package-Manager: Portage-3.0.17, Repoman-3.0.2
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @vaukai
Areas affected: ebuilds
Packages affected: dev-java/codemodel

dev-java/codemodel: @gentoo/java

Linked bugs

Bugs linked: 785415


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 24, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-04-24 16:44 UTC
Newest commit scanned: 1452e5c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b5bfc9fcbf/output.html

Comment on lines +18 to +19
DEPEND=">=virtual/jdk-1.8:*"
RDEPEND=">=virtual/jre-1.8:*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DEPEND=">=virtual/jdk-1.8:*"
RDEPEND=">=virtual/jre-1.8:*"
DEPEND=">=virtual/jdk-1.8"
RDEPEND=">=virtual/jre-1.8"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change would not help ...

 * Compiling ...
warning: [options] bootstrap class path not set in conjunction with -source 8
./com/sun/codemodel/util/SingleByteEncoder.java:53: warning: Surrogate is internal proprietary API and may be removed in a future release
import sun.nio.cs.Surrogate;
                 ^
./com/sun/codemodel/util/SingleByteEncoder.java:66: warning: Surrogate is internal proprietary API and may be removed in a future release
    private final Surrogate.Parser sgp = new Surrogate.Parser();
                  ^
./com/sun/codemodel/util/SingleByteEncoder.java:66: warning: Parser is internal proprietary API and may be removed in a future release
    private final Surrogate.Parser sgp = new Surrogate.Parser();
                           ^
./com/sun/codemodel/util/SingleByteEncoder.java:66: warning: Surrogate is internal proprietary API and may be removed in a future release
    private final Surrogate.Parser sgp = new Surrogate.Parser();
                                             ^
./com/sun/codemodel/util/SingleByteEncoder.java:66: warning: Parser is internal proprietary API and may be removed in a future release
    private final Surrogate.Parser sgp = new Surrogate.Parser();
                                                      ^
./com/sun/codemodel/util/SingleByteEncoder.java:103: warning: Surrogate is internal proprietary API and may be removed in a future release
                if (Surrogate.is(c)) {
                    ^
./com/sun/codemodel/util/SingleByteEncoder.java:136: warning: Surrogate is internal proprietary API and may be removed in a future release
                if (Surrogate.is(c)) {

@fordfrog
Copy link
Contributor

i'd last-rite both dev-java/codemodel and the only package that depends on it, dev-java/istack-commons-buildtools. any objections?

@vaukai
Copy link
Contributor Author

vaukai commented Apr 25, 2021

i'd last-rite both dev-java/codemodel and the only package that depends on it, dev-java/istack-commons-buildtools. any objections?

For me ok. (Don't forget to refer to the bug when adding to package.mask)

@fordfrog
Copy link
Contributor

ok, putting it on my list and closing this one as obsolete.

@fordfrog fordfrog closed this Apr 25, 2021
@vaukai vaukai deleted the codemodel branch April 25, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
5 participants