New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-arch/snappy: update to 1.1.9 #20692
Conversation
Pull Request assignmentSubmitter: @winterheart app-arch/snappy: @gentoo/proxy-maint (maintainer needed) Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2021-05-05 18:44 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
1a968fa
to
70d9ed8
Compare
Pull request CI reportReport generated at: 2021-05-05 21:04 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
70d9ed8
to
a056908
Compare
Taking maitainership, cleanup ebuild. Package-Manager: Portage-3.0.18, Repoman-3.0.2 Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
a056908
to
61c5e23
Compare
Pull request CI reportReport generated at: 2021-05-17 16:50 UTC New issues caused by PR: There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
-DSNAPPY_BUILD_BENCHMARKS=OFF | ||
# we do not want to run benchmarks, and those are only used | ||
# for benchmarks | ||
-DHAVE_LIBZ=NO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zlib support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read the comment above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmhm, somehow I connected it with the build option above the comment. I'll update the comment.
# for benchmarks | ||
-DHAVE_LIBZ=NO | ||
-DHAVE_LIBLZO2=NO | ||
-DHAVE_LIBLZ4=NO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lz4 compression support? Why not make these toggleable?
SRC_URI="https://github.com/google/${PN}/archive/${PV}.tar.gz -> ${P}.tar.gz" | ||
|
||
LICENSE="BSD" | ||
SLOT="0/${PV%%.*}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is necessary,
SONAME libsnappy.so.1
Taking maitainership, cleanup ebuild.
Package-Manager: Portage-3.0.18, Repoman-3.0.2
Signed-off-by: Azamat H. Hackimov azamat.hackimov@gmail.com