Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-fs/cryfs: bump to 0.10.3 #20733

Closed
wants to merge 1 commit into from
Closed

sys-fs/cryfs: bump to 0.10.3 #20733

wants to merge 1 commit into from

Conversation

AltF02
Copy link
Contributor

@AltF02 AltF02 commented May 9, 2021

No description provided.

@thesamesam
Copy link
Member

thesamesam commented May 9, 2021

Thanks! Can you commit with 'repoman commit' or 'pkgdev commit' to ensure that the commit message is right?

Also, we avoid 'git mv' in general because we need to keep the old version around. The new version needs to be committed with unstable keywords (ekeyword ~all foo.ebuild).

The bot should shortly give some other needed information.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @DankDumpster
Areas affected: ebuilds
Packages affected: sys-fs/cryfs

sys-fs/cryfs: @aristocrates, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels May 9, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-05-09 03:14 UTC
Newest commit scanned: 8b2846c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fd1b6862e0/output.html

@AltF02
Copy link
Contributor Author

AltF02 commented May 9, 2021

Sorry for that, it should be fixed now! 😄

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-05-09 03:24 UTC
Newest commit scanned: fb17ef9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b729580c9a/output.html

@AltF02
Copy link
Contributor Author

AltF02 commented May 9, 2021

@thesamesam could you take a look?

@thesamesam
Copy link
Member

thesamesam commented May 9, 2021

Looking good!

Two questions:

  1. If the patches are the same (not checked), no need to copy them, just change the reference in the new ebuild
  2. Can you add the GCO sign off with your name?

@AltF02
Copy link
Contributor Author

AltF02 commented May 9, 2021

Sorry forgot the gco sign off

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-05-09 08:49 UTC
Newest commit scanned: 6aa5432
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3994883f39/output.html

Package-Manager: Portage-3.0.18, Repoman-3.0.3
Signed-off-by: Matthew Bakhtiari <dev@mtbk.me>
@AltF02
Copy link
Contributor Author

AltF02 commented May 9, 2021

@thesamesam sorry for mention but is the sign off correct?

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-05-09 09:29 UTC
Newest commit scanned: ca3c28b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b34f3470ba/output.html

@thesamesam
Copy link
Member

Looks great now! Can test later :)

@thesamesam thesamesam self-requested a review May 9, 2021 09:41
PATCHES=(
# TODO upstream:
"${FILESDIR}/0.10.2-unbundle-libs.patch"
"${FILESDIR}/0.10.2-install-targets.patch"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to test after changing ;)

You're missing a ${PN} here. It doesn't apply right now:

>>> Preparing source in /var/tmp/portage/sys-fs/cryfs-0.10.3/work ...
 * Applying 0.10.2-unbundle-libs.patch ...
/var/tmp/portage/sys-fs/cryfs-0.10.3/temp/environment: line 1611: /var/tmp/portage/sys-fs/cryfs-0.10.3/files/0.10.2-unbundle-libs.patch: No such file or directory
/var/tmp/portage/sys-fs/cryfs-0.10.3/temp/environment: line 1614: /var/tmp/portage/sys-fs/cryfs-0.10.3/files/0.10.2-unbundle-libs.patch: No such file or directory     [ !! ]
 * ERROR: sys-fs/cryfs-0.10.3::gentoo failed (prepare phase):
 *   patch -p1  failed with /var/tmp/portage/sys-fs/cryfs-0.10.3/files/0.10.2-unbundle-libs.patch
 *
 * Call stack:
 *               ebuild.sh, line  125:  Called src_prepare
 *             environment, line 3516:  Called cmake_src_prepare
 *             environment, line 1528:  Called default_src_prepare
 *      phase-functions.sh, line  920:  Called __eapi6_src_prepare
 *             environment, line  237:  Called eapply '/var/tmp/portage/sys-fs/cryfs-0.10.3/files/0.10.2-unbundle-libs.patch' '/var/tmp/portage/sys-fs/cryfs-0.10.3/files/0.10.2-install-targets.patch'
 *             environment, line 1679:  Called _eapply_patch '/var/tmp/portage/sys-fs/cryfs-0.10.3/files/0.10.2-unbundle-libs.patch'
 *             environment, line 1617:  Called __helpers_die 'patch -p1  failed with /var/tmp/portage/sys-fs/cryfs-0.10.3/files/0.10.2-unbundle-libs.patch'
 *   isolated-functions.sh, line  112:  Called die
 * The specific snippet of code:
 *              die "$@"
 *
 * If you need support, post the output of `emerge --info '=sys-fs/cryfs-0.10.3::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=sys-fs/cryfs-0.10.3::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/sys-fs/cryfs-0.10.3/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/sys-fs/cryfs-0.10.3/temp/environment'.
 * Working directory: '/var/tmp/portage/sys-fs/cryfs-0.10.3/work'
 * S: '/var/tmp/portage/sys-fs/cryfs-0.10.3/work'

I'll fix

@thesamesam
Copy link
Member

Cheers, I applied the GCC 11 patch too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
4 participants