Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-wireless/wavemon-0.9.3: fix ncurses(w) libs #20749

Closed
wants to merge 1 commit into from
Closed

net-wireless/wavemon-0.9.3: fix ncurses(w) libs #20749

wants to merge 1 commit into from

Conversation

mehw
Copy link
Contributor

@mehw mehw commented May 10, 2021

Fixes a segmentation fault due to linking with libncursesw and libtinfo, rather than libtinfow.

See also uoaerg/wavemon#88 about the segmentation fault error.

If libncursesw is available uses ncursesw_LIBS, otherwise uses ncurses_LIBS if libncurses remains the only option.

Closes: https://bugs.gentoo.org/785562
Signed-off-by: Matteo Bianco mehw.is.me@inventati.org

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 10, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-05-10 07:24 UTC
Newest commit scanned: 92f7c6a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ea326da563/output.html

@mehw
net-wireless/wavemon-0.9.3: fix ncurses(w) libs
685a06e 
Fixes a segmentation fault due to linking with libncursesw and
libtinfo, rather than libtinfow.

See also uoaerg/wavemon#88 about the
segmentation fault error.

If libncursesw is available uses ncursesw_LIBS, otherwise uses
ncurses_LIBS if libncurses remains the only option.

Closes: https://bugs.gentoo.org/785562
Signed-off-by: Matteo Bianco <mehw.is.me@inventati.org>
@mehw mehw changed the title net-wireless/wavemon-0.9.3: fix ncurses(w) libs net-wireless/wavemon-0.9.3: fix ncurses(w) libs [please reassign] May 10, 2021
@gentoo-bot gentoo-bot changed the title net-wireless/wavemon-0.9.3: fix ncurses(w) libs [please reassign] net-wireless/wavemon-0.9.3: fix ncurses(w) libs May 10, 2021
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mehw
Areas affected: ebuilds
Packages affected: net-wireless/wavemon

net-wireless/wavemon: @alarig, @gentoo/proxy-maint

Linked bugs

Bugs linked: 785562

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 10, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-05-10 08:44 UTC
Newest commit scanned: 685a06e
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/08b2743398/output.html#global

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/08b2743398/output.html

@alarig
Copy link
Contributor

alarig commented May 12, 2021

The CI doesn’t speak about wavemon, so this PR looks good to me

@mehw
Copy link
Contributor Author

mehw commented May 13, 2021

The CI doesn’t speak about wavemon, so this PR looks good to me

@alarig thanks for checking.

juippis
juippis approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to revbump the 0.9.3 since you mentioned this is a runtime issue rather than a build issue. Thanks!

@gentoo-bot gentoo-bot closed this in cd2fe78 Jun 3, 2021
@mehw mehw deleted the fix_wavemon_ncurses branch October 18, 2021 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
5 participants
@mehw @gentoo-repo-qa-bot @gentoo-bot @alarig @juippis