Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-libs/opencv: version bump to 4.5.2 #20762

Closed
wants to merge 1 commit into from

Conversation

rossbridger
Copy link
Contributor

Relevant outstanding bugs:

Bug: https://bugs.gentoo.org/787998
Bug: https://bugs.gentoo.org/788712
Bug: https://bugs.gentoo.org/783102

Package-Manager: Portage-3.0.18, Repoman-3.0.3
Signed-off-by: Ross Charles Campbell rossbridger.cc@gmail.com

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @rossbridger
Areas affected: ebuilds
Packages affected: media-libs/opencv

media-libs/opencv: @Amynka

Linked bugs

Bugs linked: 788712, 783102, 787998


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 10, 2021
Relevant outstanding bugs:

Bug: https://bugs.gentoo.org/787998
Bug: https://bugs.gentoo.org/788712
Bug: https://bugs.gentoo.org/783102

Package-Manager: Portage-3.0.18, Repoman-3.0.3
Signed-off-by: Ross Charles Campbell <rossbridger.cc@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-05-11 00:19 UTC
Newest commit scanned: 4b54792
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/49f98e1e2b/output.html#global

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/49f98e1e2b/output.html

@thesamesam thesamesam self-requested a review May 18, 2021 06:44
Copy link
Member

@a17r a17r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reintroduces dependency on virtual/lapacke which was dropped in de5c0d7
Also you are changing virtual/jre and virtual/jdk dependency (has implications on how it is built) and slot op (looks to be a mistake), maybe @vaukai or @fordfrog can tell you more about it. See also https://archives.gentoo.org/gentoo-dev/message/71ec6a505f3245496d343c506ad21717

I don't see other ebuild changes compared to 4.5.1. How are the linked bugs related, are they definitely fixed by upstream, or do we just hope they are?

lapack? (
virtual/cblas
virtual/lapack
virtual/lapacke
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try building without having virtual/lapacke installed and if it works remove this dependency.

@vaukai
Copy link
Contributor

vaukai commented May 23, 2021

maybe @vaukai or @fordfrog can tell you more about it. See also https://archives.gentoo.org/gentoo-dev/message/71ec6a505f3245496d343c506ad21717

nothing to add, 1.8:* should be tried in first place.

>=virtual/jdk-1.8:*
>=virtual/jre-1.8:*

@steils
Copy link
Member

steils commented May 23, 2021

I'm not sure any of these three bugs are relevant to the version upgrade. Also I'm not able to reproduce them with 4.5.1 either (but I don't have a no-mutilib system or a system with nvidia, so I could really try only the bug 787998).
I suggest not to mention them in the commit message. Perhaps close the bugs as obsolete. If some of them are still actual for 4.5.2, they can be reopened.

@rossbridger rossbridger deleted the media-libs/opencv branch May 23, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
7 participants