Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdr-plugin-2.eclass: fix pkgcheck findings #20845

Closed
wants to merge 1 commit into from

Conversation

madmartin
Copy link
Contributor

@madmartin madmartin commented May 16, 2021

vdr-plugin-2.eclass: fix pkgcheck findings in documentation

Add documentation to eclass functions and variables as found by pkgcheck,
no functional changes.

pkgcheck reported:
EclassDocMissingFunc: vdr-plugin-2: undocumented functions: has_vdr,
vdr-plugin-2_print_enable_command, vdr-plugin-2_src_util,
vdr_create_header_checksum_file, vdr_create_plugindb_file, vdr_detect_po_dir,
vdr_gettext_missing, vdr_i18n, vdr_linguas_support, vdr_patchmakefile
EclassDocMissingVar: vdr-plugin-2: undocumented variables: COMMON_DEPEND, VDRPLUGIN

Signed-off-by: Martin Dummer martin.dummer@gmx.net

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @madmartin
Areas affected: eclasses
Packages affected: (none)

@gentoo/github

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added the need assignment It was impossible to assign the PR correctly. Please assign it manually. label May 16, 2021
@mjeveritt
Copy link
Contributor

FYI, you will probably find that most devs will request a patch be sent to the mailing list itself, as many don't look at github.
TIA for the fixes though!

@juippis
Copy link
Member

juippis commented Jun 7, 2021

@mgorny any comments here?

Add documentation to eclass functions and variables as found by pkgcheck,
no functional changes.

pkgcheck reported:
EclassDocMissingFunc: vdr-plugin-2: undocumented functions: has_vdr,
  vdr-plugin-2_print_enable_command, vdr-plugin-2_src_util,
  vdr_create_header_checksum_file, vdr_create_plugindb_file, vdr_detect_po_dir,
  vdr_gettext_missing, vdr_i18n, vdr_linguas_support, vdr_patchmakefile
EclassDocMissingVar: vdr-plugin-2: undocumented variables: COMMON_DEPEND, VDRPLUGIN

Signed-off-by: Martin Dummer <martin.dummer@gmx.net>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-06-22 07:56 UTC
Newest commit scanned: b19db35
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/17e8f620be/output.html

@madmartin madmartin deleted the vdr-eclass branch June 22, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need assignment It was impossible to assign the PR correctly. Please assign it manually.
Projects
None yet
5 participants