Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/*sphinx*: bump to python 3.9 #21024

Closed
wants to merge 11 commits into from
Closed

Conversation

arthurzam
Copy link
Member

@mgorny Fifth batch. Here is a little more specialized python bump. I tried here to bump all sphinx related ebuilds to python 3.9. All were tested using various examples I found, while for most of them dev-python/aiohttp[doc] was really good test.

  1. For dev-python/sphinxcontrib-doxylink I moved to github archives for using the test suite (and now it has tests and even passes them!)
  2. For dev-python/sphinxcontrib-newsfeed I fixed QA notice given by pkgcheck about insinto for newer version
  3. For dev-python/sphinxcontrib-asyncio I managed to port and fix for sphinx>=4.0. Now it successfully builds self docs and aiohttp so I think my change is working properly. Sadly, upstream is dead so no reason to push upstream the patch.

As always, I put every change info and explanation into commit description.

Note:
I think we should mask and remove dev-python/sphinxcontrib-httpdomain. This package doesn't import and has non trivial error since sphinx>=4.0, as a result fails current tests, and only revdep is dev-python/sphinxcontrib-httpexample which is masked (by you here with same problem). I think we can even reuse the same description for the mask :)

- fix for `dev-python/sphinx` >= 4.0. Now successfully generates self docs
- bump to `EAPI=7`
- use `distutils_enable_sphinx` for docs
- bump to python 3.9

Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
passes when run on demo example

Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
- move to github releases for tests support
- `app-doc/doxygen` is needed for tests

Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @arthurzam
Areas affected: ebuilds
Packages affected: dev-python/sphinx-aiohttp-theme, dev-python/sphinxcontrib-asyncio, dev-python/sphinxcontrib-doxylink, dev-python/sphinxcontrib-github-alt, dev-python/sphinxcontrib-newsfeed

dev-python/sphinx-aiohttp-theme: @zmedico
dev-python/sphinxcontrib-asyncio: @gentoo/python
dev-python/sphinxcontrib-doxylink: aballier, @gentoo/python
dev-python/sphinxcontrib-github-alt: @gentoo/sci
dev-python/sphinxcontrib-newsfeed: @gentoo/proxy-maint (maintainer needed)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels May 28, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-05-28 17:09 UTC
Newest commit scanned: ab3e6ad
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/349d1aab25/output.html

Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Awesome work, as always. I have kernel bumps batched, so it will take a while before I push this.

If you have a minute, PM me on IRC and let's discuss making you a dev.


src_prepare() {
# fix for sphinx >= 4.0
sed -i sphinxcontrib/asyncio.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've missed a \ here. I'll fix it while merging.

mgorny pushed a commit to mgorny/gentoo that referenced this pull request May 28, 2021
Signed-off-by: Zamarin Arthur <arthurzam@gmail.com>
Closes: gentoo#21024
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants