sci-libs/opencascade[vtk]: prevent name collision #21105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VTK-9.0 declares in their headers 'struct AllValues' which collides with a macro defined by GLX. This has been only partially fixed in the upstream: https://git.dev.opencascade.org/gitweb/?p=occt.git;a=commit;h=2c276f91da0 It was necessary to put `#undef`s in a few other places. Closes: https://bugs.gentoo.org/794031 Signed-off-by: Roman Beranek <roman.beranek@prusa3d.com>
Pull Request assignmentSubmitter: @zavorka sci-libs/opencascade: @waebbl, @gentoo/proxy-maint Linked bugsBugs linked: 794031 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2021-06-03 14:34 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
This was referenced Jun 6, 2021
waebbl
approved these changes
Jun 7, 2021
|
Could you rebase please? |
|
@zavorka ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VTK-9.0 declares in their headers 'struct AllValues' which collides with
a macro defined by GLX.
This has been only partially fixed in the upstream:
https://git.dev.opencascade.org/gitweb/?p=occt.git;a=commit;h=2c276f91da0
It was necessary to put
#undefs in a few other places.Closes: https://bugs.gentoo.org/794031
Signed-off-by: Roman Beranek roman.beranek@prusa3d.com