Cura 4.9.1 #21150

MathyV · 2021-06-07T16:06:32Z

Version bump (https://bugs.gentoo.org/793803)

This PR also adds python 3.9 to the ebuilds and fixes a potential dependency issue (https://bugs.gentoo.org/731274)

gentoo-bot · 2021-06-07T16:08:05Z

Pull Request assignment

Submitter: @MathyV
Areas affected: ebuilds
Packages affected: dev-libs/libarcus, dev-libs/libcharon, dev-libs/libsavitar, dev-python/pynest2d, dev-python/uranium...

dev-libs/libarcus: @gentoo/3dprint, @alexxy, @gentoo/proxy-maint, @MathyV, @Perlovka
dev-libs/libcharon: @gentoo/3dprint, @alexxy, @gentoo/proxy-maint, @MathyV, @Perlovka
dev-libs/libsavitar: @gentoo/3dprint, @alexxy, @gentoo/proxy-maint, @MathyV, @Perlovka
dev-python/pynest2d: @gentoo/3dprint
dev-python/uranium: @gentoo/3dprint, @gentoo/python, @alexxy, @gentoo/proxy-maint, @MathyV, @Perlovka
media-gfx/cura: @gentoo/3dprint, @alexxy, @gentoo/proxy-maint, @MathyV, @Perlovka
media-gfx/curaengine: @gentoo/3dprint, @alexxy, @gentoo/proxy-maint, @MathyV, @Perlovka
media-gfx/fdm-materials: @gentoo/3dprint, @alexxy, @gentoo/proxy-maint, @MathyV, @Perlovka

Linked bugs

Bugs linked: 731274, 793803

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2021-06-07T16:24:12Z

Pull request CI report

Report generated at: 2021-06-07 16:24 UTC
Newest commit scanned: a992e04
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/464965947b/output.html

MathyV · 2021-06-07T18:07:28Z

Looks like I jumped the gun a bit and missed a new python dependency keyring, checking if I missed any else

MathyV · 2021-06-07T18:26:04Z

I added keyring, importlib_metadata and PyQt5-sip since they were added to requirements.txt in Ultimaker/Cura@8bc2c71 I left the other dependencies alone since they only got an update.

gentoo-repo-qa-bot · 2021-06-07T18:39:12Z

Pull request CI report

Report generated at: 2021-06-07 18:39 UTC
Newest commit scanned: ff8f3c1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/45ab76e71e/output.html

expeditioneer

Thank you for your contribution. Could you have a look at my review comments?

expeditioneer · 2021-06-07T18:50:13Z

dev-libs/libarcus/files/libarcus-4.9.1-deprecated-protobuf-calls.patch

@@ -0,0 +1,30 @@
+--- a/src/Socket_p.h


This file has the same content as libarcus-4.8.0-deprecated-protobuf-calls.patch please reference this instead.

My reasoning was that I expect 4.8.0 to disappear soon because of no Python 3.9 in the ebuilds, yet I didn't want to touch the ebuild contents, but okay, I'll adapt it.

@expeditioneer is it okay if I rename the file to be versionless and update 4.8.0 also without a revbump?

@MathyV i would like to have the version number when this patch was first introduced so it is IMHO better to keep track when this patch was first introduced. This is not a strong opinion i could also be happy with a versionless patch.

expeditioneer · 2021-06-07T18:55:16Z

dev-python/pynest2d/files/pynest2d-4.9.1-fix-cpp-version.patch

@@ -0,0 +1,11 @@
+--- a/CMakeLists.txt


This file has the same content as pynest2d-4.8.0-fix-cpp-version.patch please reference this instead.

expeditioneer · 2021-06-07T18:56:11Z

dev-python/pynest2d/files/pynest2d-4.9.1-required-flags-from-Libnest2D-target.patch

@@ -0,0 +1,24 @@
+See https://github.com/Ultimaker/pynest2d/pull/3


This file has the same content as pynest2d-4.8.0-required-flags-from-Libnest2D-target.patch please reference this instead.

expeditioneer · 2021-06-07T19:09:32Z

media-gfx/cura/cura-4.9.1.ebuild

+	~dev-python/uranium-${PV}[${PYTHON_SINGLE_USEDEP}]
+	~media-gfx/curaengine-${PV}
+	~media-gfx/fdm-materials-${PV}
+	dev-qt/qtquickcontrols[widgets]


should it not be dev-qt/qtquickcontrols2 ? Could you also add the slot to this dependency?

tbh I just copied these verbatim from the bug https://bugs.gentoo.org/731274 I will ask the original submitter to comment here

expeditioneer · 2021-06-07T19:10:17Z

media-gfx/cura/cura-4.9.1.ebuild

+	~media-gfx/curaengine-${PV}
+	~media-gfx/fdm-materials-${PV}
+	dev-qt/qtquickcontrols[widgets]
+	dev-python/PyQt5[-debug]


dev-python/PyQt5 already listed on Line37

hrnick · 2021-06-07T19:48:35Z

Sorry, that could have been me who did not keep track on the ebuilds in my local repository when patching.

I have not been able to start cura for the past year due to qtquickcontrols not being build with the widgets USE flag (only qtquickcontrols, qtquickcontrols2 does not seem to matter when I tested). While troubleshooting and enabling the debug USE flag for a number of packages I came across the following bug:

Ultimaker/Cura#8875

I have tested that and it's happens for cura-4.9.1 as well.

So sorry for the mistake with having multiple PyQt5s in the ebuild but USE="-debug" has to be used for PyQt5 in order for cura to start.

hrnick · 2021-06-08T14:52:45Z

Another comment; I also changed the sip dependency in the libarcus ebuild to use <dev-python/sip-5.5.0 in my local repository since dev-python/sip-5.5.0 seems to break it (ModuleNotFoundError: No module named 'sip' when emerging).

expeditioneer · 2021-06-09T13:04:11Z

@hrnick the dependency should be <dev-python/sip-5[${PYTHON_MULTI_USEDEP}] because libarcus is no SIP 5 compatible, see Ultimaker/libArcus#114

Closes: https://bugs.gentoo.org/793803 Package-Manager: Portage-3.0.19, Repoman-3.0.3 Signed-off-by: Mathy Vanvoorden <mathy@vanvoorden.be>

Closes: https://bugs.gentoo.org/793803 Closes: https://bugs.gentoo.org/731274 Package-Manager: Portage-3.0.19, Repoman-3.0.3 Signed-off-by: Mathy Vanvoorden <mathy@vanvoorden.be>

MathyV · 2021-06-10T07:05:50Z

I updated the ebuilds:

Removed the duplicate patches
Merged the two pyqt5 use deps

As I also commented in https://bugs.gentoo.org/795072 there is already a hard dependency on < sip-5 in libarcus so not sure why you are seeing this @hrnick , my best bet is that you are building with ebuild or emerging with --nodeps, on my system portage respects the blocker and downgrades sip.

gentoo-repo-qa-bot · 2021-06-10T07:15:54Z

Pull request CI report

Report generated at: 2021-06-10 07:15 UTC
Newest commit scanned: c235291
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1a5db85a4a/output.html

expeditioneer · 2021-06-10T17:00:41Z

@MathyV Thank you for your contribution! I'll merge this in a few seconds.

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jun 7, 2021

expeditioneer self-assigned this Jun 7, 2021

MathyV force-pushed the cura-4.9.1 branch from a992e04 to ff8f3c1 Compare June 7, 2021 18:25

expeditioneer suggested changes Jun 7, 2021

View reviewed changes

MathyV added 5 commits June 10, 2021 09:00

dev-libs/libarcus: Version bump

82e2d6e

Closes: https://bugs.gentoo.org/793803 Package-Manager: Portage-3.0.19, Repoman-3.0.3 Signed-off-by: Mathy Vanvoorden <mathy@vanvoorden.be>

dev-python/uranium: Version bump to 4.9.1

5e02a77

Closes: https://bugs.gentoo.org/793803 Package-Manager: Portage-3.0.19, Repoman-3.0.3 Signed-off-by: Mathy Vanvoorden <mathy@vanvoorden.be>

media-gfx/curaengine: Version bump to 4.9.1

0d95f47

Closes: https://bugs.gentoo.org/793803 Package-Manager: Portage-3.0.19, Repoman-3.0.3 Signed-off-by: Mathy Vanvoorden <mathy@vanvoorden.be>

media-gfx/fdm-materials: Version bump: 4.9.1

aa8d6e8

Closes: https://bugs.gentoo.org/793803 Package-Manager: Portage-3.0.19, Repoman-3.0.3 Signed-off-by: Mathy Vanvoorden <mathy@vanvoorden.be>

dev-libs/libsavitar: Version bump to 4.9.1

45ec943

Closes: https://bugs.gentoo.org/793803 Package-Manager: Portage-3.0.19, Repoman-3.0.3 Signed-off-by: Mathy Vanvoorden <mathy@vanvoorden.be>

MathyV force-pushed the cura-4.9.1 branch from ff8f3c1 to 7ba5e69 Compare June 10, 2021 07:00

MathyV added 3 commits June 10, 2021 09:03

dev-python/pynest2d: Version bump to 4.9.1

90d3d20

Closes: https://bugs.gentoo.org/793803 Package-Manager: Portage-3.0.19, Repoman-3.0.3 Signed-off-by: Mathy Vanvoorden <mathy@vanvoorden.be>

dev-libs/libcharon: Version bump to 4.9.1

68d5693

Closes: https://bugs.gentoo.org/793803 Package-Manager: Portage-3.0.19, Repoman-3.0.3 Signed-off-by: Mathy Vanvoorden <mathy@vanvoorden.be>

media-gfx/cura: Version bump to 4.9.1

c235291

Closes: https://bugs.gentoo.org/793803 Closes: https://bugs.gentoo.org/731274 Package-Manager: Portage-3.0.19, Repoman-3.0.3 Signed-off-by: Mathy Vanvoorden <mathy@vanvoorden.be>

MathyV force-pushed the cura-4.9.1 branch from 7ba5e69 to c235291 Compare June 10, 2021 07:04

gentoo-bot closed this in a32c3cd Jun 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cura 4.9.1 #21150

Cura 4.9.1 #21150

MathyV commented Jun 7, 2021

gentoo-bot commented Jun 7, 2021

gentoo-repo-qa-bot commented Jun 7, 2021

MathyV commented Jun 7, 2021

MathyV commented Jun 7, 2021 •

edited

gentoo-repo-qa-bot commented Jun 7, 2021

expeditioneer left a comment

expeditioneer Jun 7, 2021

MathyV Jun 7, 2021

MathyV Jun 7, 2021

expeditioneer Jun 9, 2021

expeditioneer Jun 7, 2021

expeditioneer Jun 7, 2021

expeditioneer Jun 7, 2021

MathyV Jun 7, 2021

expeditioneer Jun 7, 2021

hrnick commented Jun 7, 2021

hrnick commented Jun 8, 2021

expeditioneer commented Jun 9, 2021

MathyV commented Jun 10, 2021

gentoo-repo-qa-bot commented Jun 10, 2021

expeditioneer commented Jun 10, 2021

		@@ -0,0 +1,24 @@
		See https://github.com/Ultimaker/pynest2d/pull/3

Cura 4.9.1 #21150

Cura 4.9.1 #21150

Conversation

MathyV commented Jun 7, 2021

gentoo-bot commented Jun 7, 2021

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented Jun 7, 2021

Pull request CI report

MathyV commented Jun 7, 2021

MathyV commented Jun 7, 2021 • edited

gentoo-repo-qa-bot commented Jun 7, 2021

Pull request CI report

expeditioneer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hrnick commented Jun 7, 2021

hrnick commented Jun 8, 2021

expeditioneer commented Jun 9, 2021

MathyV commented Jun 10, 2021

gentoo-repo-qa-bot commented Jun 10, 2021

Pull request CI report

expeditioneer commented Jun 10, 2021

MathyV commented Jun 7, 2021 •

edited