Bump rdma-core to 34.1 and make it suitable for Prefix

[bedroge]

Signed-off-by: Bob Dröge b.e.droge@rug.nl

[gentoo-bot]

Pull Request assignment

Submitter: @bedroge
Areas affected: ebuilds
Packages affected: sys-cluster/rdma-core

sys-cluster/rdma-core: @Zlogene

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[bedroge]

@amadio suggested that the following:

        if use python; then
                mycmakeargs+=( -DNO_PYVERBS=OFF -DPYTHON_EXECUTABLE="${PYTHON}" )
        else
                mycmakeargs+=( -DNO_PYVERBS=ON )
        fi

can perhaps be reduced to:

        mycmakeargs+=( -DNO_PYVERBS=$(usex python OFF ON) )

?

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2021-06-17 10:24 UTC
Newest commit scanned: 808ed51
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/50788fc101/output.html

[amadio]

@amadio suggested that the following:

        if use python; then
                mycmakeargs+=( -DNO_PYVERBS=OFF -DPYTHON_EXECUTABLE="${PYTHON}" )
        else
                mycmakeargs+=( -DNO_PYVERBS=ON )
        fi

can perhaps be reduced to:

        mycmakeargs+=( -DNO_PYVERBS=$(usex python OFF ON) )

?

Yes, please do that, you can add it to the list above and remove this if statement completely.

[amadio]

Also, Gentoo has a convention for commit messages, so the message should be something like:
sys-cluster/rdma-core: version bump, make it suitable for prefix
You should also use repoman commit if you can, so that it adds a signoff line for you (or git commit --signoff at least).
(I can do these things upon merging, but it's good to get in the habit of following these, as it will speedup merging of future merge requests, and help catch errors).

[bedroge]

Ah, good to know, thanks! Will do that next time.

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2021-06-17 12:14 UTC
Newest commit scanned: 810d34d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4e4adb68a5/output.html

[Zlogene]

Hello, please fix commits headline.

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2021-06-22 11:40 UTC
Newest commit scanned: 8616a69
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c48a4c19e7/output.html

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2021-06-22 13:45 UTC
Newest commit scanned: a5153c5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e84af093fa/output.html

[Zlogene]

@bedroge: few notes:

1. Please squash your python improvements into a single bump commit
2. You [rpbably wanna try to update it to 35.0 (yes, delays on my end with merges, sorry)

[bedroge]

@Zlogene I hadn't noticed that 35.0 was already available, but I quickly tested it, and it seems to work with the same ebuild. Do you want me to close this PR and open a new one for 35.0?

[Zlogene]

@bedroge whatever most convinient for you :)

[bedroge]

@Zlogene: it took a bit longer due to vacation, but I just opened a new PR for rdma-core 36.0: #22092. So I'm closing this PR.