Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfce-extra/xfce4-whiskermenu-plugin: version bumps #2132

Closed
wants to merge 4 commits into from
Closed

xfce-extra/xfce4-whiskermenu-plugin: version bumps #2132

wants to merge 4 commits into from

Conversation

tietzc
Copy link
Contributor

@tietzc tietzc commented Aug 23, 2016

Gentoo-Bug: https://bugs.gentoo.org/591914

From version 2.0.0 onward Whisker Menu depends on >=xfce-base/exo-0.11.0 which is currently masked. So xfce-extra/xfce4-whiskermenu-plugin-2.0.1 needs to be added to package.mask as well. Alternatively we could of course only go for 1.6.0 now and wait with 2.0.1 until exo gets unmasked. Do as you please.

Moreover, unlike mentioned in the bug report, xfce4-whiskermenu-plugin-2.0.1 depends only on >=x11-libs/gtk+-3.12 and not 3.18.

@monsieurp @perfinion

einfo "removing ${i%.po} linguas"
has ${i%.po} ${LINGUAS} || { rm ${i} || die ; }
done
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this explicit deleting of gettext files is not in accordance anymore with the latest policies of Gentoo on handling LINGUAS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgorny Am I right in that the current Gentoo LINGUAS/L10N policy discourages deleting/editing out localisations?

@monsieurp monsieurp self-assigned this Aug 25, 2016
@monsieurp monsieurp added bugfix assigned PR successfully assigned to the package maintainer(s). labels Aug 25, 2016
@tietzc
Copy link
Contributor Author

tietzc commented Aug 25, 2016

Thanks for the input. Preference of default over eapply_user and deletion of src_install() are no-brainers. The slot operators seem to be fine. But could you please go a bit more into detail about how unnecessary gettext files should be handled in accordance with current LINGUAS respectively L10N policies?

@ketetefid
Copy link

I am sorry for my question. I was wondering when this will be merged into the portage. Is there an ETA for this?

virtual/pkgconfig"

src_prepare() {
default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I just noticed - if you use cmake-utils, you should use cmake-utils_src_prepare instead of default. Sorry, this was an oversight on my side.

@tietzc
Copy link
Contributor Author

tietzc commented Aug 29, 2016

Switched from default to cmake-utils_src_prepare.

@monsieurp
Copy link
Member

Could you please rebase against master? It's a few commits behind (package.mask has been modified since) and I cannot merge cleanly. Thanks.

@tietzc
Copy link
Contributor Author

tietzc commented Aug 30, 2016

Done. Hope I did it correctly.

gentoo-bot pushed a commit that referenced this pull request Aug 30, 2016
Package-Manager: portage-2.2.28
Closes: #2132

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>
gentoo-bot pushed a commit that referenced this pull request Aug 30, 2016
Closes: #2132

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>
gentoo-bot pushed a commit that referenced this pull request Aug 30, 2016
Package-Manager: portage-2.2.28
Closes: #2132

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>
@tietzc tietzc deleted the whiskermenu-bump branch August 30, 2016 19:41
winterheart pushed a commit to winterheart/gentoo that referenced this pull request Sep 4, 2016
Package-Manager: portage-2.2.28
Closes: gentoo#2132

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>
winterheart pushed a commit to winterheart/gentoo that referenced this pull request Sep 4, 2016
Package-Manager: portage-2.2.28
Closes: gentoo#2132

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>
winterheart pushed a commit to winterheart/gentoo that referenced this pull request Sep 4, 2016
Closes: gentoo#2132

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>
winterheart pushed a commit to winterheart/gentoo that referenced this pull request Sep 4, 2016
Package-Manager: portage-2.2.28
Closes: gentoo#2132

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s).
Projects
None yet
5 participants