sys-devel/llvm-roc: Version bump to 4.2.0 and QA

[justxi]

Signed-off-by: Wilfried Holzke gentoo@holzke.net
Package-Manager: Portage-3.0.18, Repoman-3.0.2

[gentoo-bot]

Pull Request assignment

Submitter: @justxi
Areas affected: ebuilds
Packages affected: sys-devel/llvm-roc

sys-devel/llvm-roc: @candrews

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2021-06-20 09:26 UTC
Newest commit scanned: e6026ae
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fbf5064e10/output.html

[justxi]

@candrews Anything wrong with this?

[candrews]

Looks good! Sorry for the delay

[justxi]

No problem. Now I can push the other ebuilds.

[candrews]

No problem. Now I can push the other ebuilds.

This PR introduced a bug: https://bugs.gentoo.org/798927

Can you please address it?

[justxi]

Yes... sorry... added an old ebuild :(.

[justxi]

@candrews Here you will find an update... #21473

[heroxbd]

@justxi have you documented the rationale removing hip-4.0.0-hip-location.patch？

[justxi]

@heroxbd No. It did not apply and if I remember correctly, I was already applied. Otherwise I would had created an updated patch.

[heroxbd]

@heroxbd No. It did not apply and if I remember correctly, I was already applied. Otherwise I would had created an updated patch.

It was removed without a refreshed patch.

[justxi]

As I said, I think the patch was no longer necessary.

[heroxbd]

As I said, I think the patch was no longer necessary.

Clarified, thanks!

The patch is still necessary to let llvm-roc find HIP in Gentoo. It worked because of the ROCM_PATH in /etc/env.d. I would like to minimize the usage of environment variables for ROCm and reintroduce this patch.