New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
media-libs/{ilmbase,openexr}, dev-python/pyilmbase: bump to 2.5.7 #21373
Conversation
Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
Closes: https://bugs.gentoo.org/656680 Bug: https://bugs.gentoo.org/776808 Bug: https://bugs.gentoo.org/787452 Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
Pull Request assignmentSubmitter: @waebbl dev-python/pyilmbase: @waebbl, @gentoo/proxy-maint Linked bugsBugs linked: 656680, 776808, 787452 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2021-06-22 12:04 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
TEST (testHuf, "core"); | ||
TEST (testWav, "core"); | ||
- TEST (testRgba, "basic"); | ||
+// TEST (testRgba, "basic"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In future, just drop the line -- we lose no information because the diff still shows what was there in the past.
I'm a bit uneasy about disabling it because it could be a genuine issue in the code (i.e. the test is exposing a problem), but I suppose it's only one. Let's keep an eye on the bug upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upstream bug doesn't had any progress lately. I keep an eye on it. It probably is an issue dedicated only to sparc machines. In the upstream bug, someone said on other big endian architectures, the issue didn't show up.
- set(libdir ${CMAKE_INSTALL_LIBDIR}) | ||
- set(includedir ${CMAKE_INSTALL_INCLUDEDIR}) | ||
+ set(exec_prefix "\${prefix}") | ||
+ set(libdir "\${exec_prefix}/${CMAKE_INSTALL_LIBDIR}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future please replace those by ${CMAKE_INSTALL_FULL_LIBDIR} for the case the patch eventually goes upstream. This will then also works for cases where the user explicitely sets e.g. an include dir that is not inside $prefix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DerDakon The patch is already upstream, but for some reason it only has found it's way into the new Imath library, but has not yet been backported to the older 2.5 branch of OpenEXR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed an issue for that: AcademySoftwareFoundation/Imath#171
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DerDakon
Closes: https://bugs.gentoo.org/656680
Bug: https://bugs.gentoo.org/776808
Bug: https://bugs.gentoo.org/787452
Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: Bernd Waibel waebbl-gentoo@posteo.net