net-p2p/litecoin*: Fixing dependency bug and version bumps #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot. I'm going to have to close this PR due to your first commit. Do not pull from master after creating your branch please, it messes up the branch altogether. File a similar PR without pulling from master this time round. Cheers. |
|
Also, fixing three bugs in one single PR is fine and encouraged. 👍 |
|
each fix should be one commit, and multiple related commits in one pr is fine |
|
No Problem! Thank you for the info. I opened a new Request: #2144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is fixing 3 bugs.
I didn't file one each, I don't know, what your preference is.
https://bugs.gentoo.org/show_bug.cgi?id=592018
https://bugs.gentoo.org/show_bug.cgi?id=592100
https://bugs.gentoo.org/show_bug.cgi?id=592112
Changes to existing ebuild and new ebuilds tested locally with qt4 and qt5.