Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EAPI 8 eclass updates #21440

Closed
wants to merge 7 commits into from
Closed

EAPI 8 eclass updates #21440

wants to merge 7 commits into from

Conversation

dm0-
Copy link
Contributor

@dm0- dm0- commented Jun 26, 2021

@mgorny Here are the last few eclass updates. The meson-multilib.eclass change has a dependency on #21409.

Aside from just adding EAPI 8 to the list of supported EAPIs, most of these changes fall into:

  • Dropping support for EAPIs that are not supported in inherited eclasses.
  • Moving the EAPI check before the inherit guard so using newer bash functionality won't result in syntax errors for old versions.
  • Setting the inherit guard variable before inherits so it prevents loops.
  • Trivial formatting unification where different styles are mixed in the same file.

@mattst88 @floppym @SoapGentoo

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @dm0-
Areas affected: eclasses
Packages affected: (none)

@gentoo/github

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added the need assignment It was impossible to assign the PR correctly. Please assign it manually. label Jun 26, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-06-26 21:11 UTC
Newest commit scanned: fc291c0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/199128cd66/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-06-26 21:36 UTC
Newest commit scanned: fc291c0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2803f3cef3/output.html

floppym
floppym suggested changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@floppym floppym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments for systemd and xdg-utils.

meson-multilib and udev look ok.

eclass/xdg-utils.eclass Show resolved Hide resolved
eclass/systemd.eclass Outdated Show resolved Hide resolved
@dm0-
Copy link
Contributor Author

dm0- commented Jun 28, 2021

I'll drop the deprecated tmpfiles removal here after #21462 is merged.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-06-29 06:51 UTC
Newest commit scanned: 5a2ee8b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a566092ce7/output.html

ulm
ulm suggested changes Jun 29, 2021
View reviewed changes
eclass/autotools.eclass Outdated Show resolved Hide resolved
eclass/xdg-utils.eclass Outdated Show resolved Hide resolved
eclass/xdg-utils.eclass Outdated Show resolved Hide resolved
eclass/xdg-utils.eclass Outdated Show resolved Hide resolved
ulm
ulm approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@ulm ulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-06-29 14:21 UTC
Newest commit scanned: 187c944
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e54fee3597/output.html

dm0- added 7 commits June 29, 2021 12:35
@dm0-
systemd.eclass: EAPI 8 support
50c6ce9 
This also drops EAPIs < 5 to match toolchain-funcs.eclass.  (Its
support for EAPI 0 is an implementation detail so crossdev can
source it, which is not relevant here.)

Signed-off-by: David Michael <fedora.dm0@gmail.com>
@dm0-
udev.eclass: EAPI 8 support
c881345 
This also drops EAPIs < 5 to match toolchain-funcs.eclass.

Signed-off-by: David Michael <fedora.dm0@gmail.com>
@dm0-
xdg-utils.eclass: EAPI 8 support
eb2c8c1 
Also standardize on one conditional block spacing syntax, drop some
redundant local variables, and remove banned EAPIs.

Signed-off-by: David Michael <fedora.dm0@gmail.com>
@dm0-
gnome.org.eclass: EAPI 8 support
6958301 
Signed-off-by: David Michael <fedora.dm0@gmail.com>
@dm0-
multilib-build.eclass: EAPI 8 support
8caa0a7 
Also drop EAPI 4 to match multilib.eclass.

Signed-off-by: David Michael <fedora.dm0@gmail.com>
@dm0-
multilib-minimal.eclass: EAPI 8 support
dead640 
Also drop EAPI 4 to match multilib-build.eclass.

Signed-off-by: David Michael <fedora.dm0@gmail.com>
@dm0-
meson-multilib.eclass: EAPI 8 support
045b384 
Signed-off-by: David Michael <fedora.dm0@gmail.com>
@dm0-
Copy link
Contributor Author

dm0- commented Jun 29, 2021

I dropped the deprecation cleanup commit since #21462 was merged and the conflict was resolved.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-06-29 16:50 UTC
Newest commit scanned: 045b384
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fb6b8b37ad/output.html

mgorny
mgorny approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gentoo-bot gentoo-bot closed this in a00eb48 Jul 2, 2021
@dm0- dm0- deleted the eclass branch July 2, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulm ulm ulm approved these changes

@floppym floppym floppym requested changes

@mgorny mgorny mgorny approved these changes

Assignees
No one assigned
Labels
need assignment It was impossible to assign the PR correctly. Please assign it manually.
Projects
None yet
Milestone
No milestone
6 participants
@dm0- @gentoo-bot @gentoo-repo-qa-bot @mgorny @ulm @floppym