app-office/libreoffice: fix ebuild bug building with clang #2145
Conversation
|
Can you double check the bug number? |
gktrk
added
bugfix
assigned
| @@ -265,7 +265,7 @@ pkg_pretend() { | |||
| if [[ ${MERGE_TYPE} != binary ]]; then | |||
| check-reqs_pkg_pretend | |||
|
|
|||
| if [[ $(tc-getCC) == clang ]] ; then | |||
| if [[ $(tc-getCC) == *clang* ]] ; then | |||
There was a problem hiding this comment.
instead of just testing for clang and then using the else code path, test only for GCC using the new tc-is-gcc function, i.e.
if tc-is-gcc; then
# gcc blabla
fi
There was a problem hiding this comment.
I'd much rather check for the exception on top (clang being used) and then have it default to GCC for whatever may go wrong there.
There was a problem hiding this comment.
It's been impacting users... including me.
There was a problem hiding this comment.
if you wish to test for clang, then use tc-is-clang instead, preferably by negating it and attaching it to the elif expressions. Don't match names.
There was a problem hiding this comment.
while you're at it, please extend the fix to all libreoffice ebuilds.
There was a problem hiding this comment.
This is still borked in the latest git pull.
There was a problem hiding this comment.
if you want to be credited with the fix, then leave this PR open, but as I said please also extend it to the other ebuilds. after all you don't want that bug re-introduced when the next libreoffice version bump is created out of an unfixed live ebuild. At the same time change to use tc-is-clang as suggested in https://github.com/gentoo/gentoo/pull/2145/files#r76622697
There was a problem hiding this comment.
@a17r Who maintains the libreoffice ebuilds? I fixed the other ebuilds for you, but this is as much time as I have to spend on this problem. At least two people are still waiting for this to be fixed.
There was a problem hiding this comment.
github is not just an alternative place to bugzilla to voice your concerns, this is where you get involved yourself to help. The (already existing) bug is enough to make maintainers aware of the issue, if that's what you want.
There was a problem hiding this comment.
It's been a week since I submitted a patch on this. That's longer than a week that people have been having issues with it. I am truly sorry, but I can't afford any more time on this.
I sincerely hope someone else fixes it.
On Wed, Aug 31, 2016 at 11:46:24AM -0700, Andreas Sturmlechner wrote:
@@ -265,7 +265,7 @@ pkg_pretend() {
if [[ ${MERGE_TYPE} != binary ]]; then
check-reqs_pkg_pretend
if [[ $(tc-getCC) == clang ]] ; thenif [[ $(tc-getCC) == _clang_ ]] ; thengithub is not just an alternative place to bugzilla to voice your concerns, this is where you get involved yourself to help. The (already existing) bug is enough to make maintainers aware of the issue, if that's what you want.
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/gentoo/gentoo/pull/2145/files/6992b9b78310bb8769a490a6deeaee1bf23aeb45#r77048658
Gentoo-Bug: 589948 Suggested-By: Jason Schulz <jason@schulz.name>
| if [[ $(tc-getCC) == clang ]] ; then | ||
| : # ignore clang, which works | ||
| elif [[ $(gcc-major-version) -lt 4 ]] || { | ||
| if [[ $(gcc-major-version) -lt 4 ]] || { |
|
@uxcn While I do understand your frustration with the whole process dragging on, we can't just accept random drive-by patches. If you want to contribute, certain minimum QA standards have to be fulfilled. |
|
Dealing with it in existing PR now: #1907 |
|
@SoapGentoo I appreciate the dilemma, I just don't have the time to spare on this. |
This fixes a bug that misidentifies clang as gcc in a compiler test.
Gentoo-Bug: 598948
Suggested-By: Jason Schulz jason@schulz.name