Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-sound/tuxguitar: New package #2149

Closed
wants to merge 1 commit into from
Closed

media-sound/tuxguitar: New package #2149

wants to merge 1 commit into from

Conversation

dracwyrm
Copy link
Contributor

@dracwyrm dracwyrm commented Aug 26, 2016

A multitrack tablature editor and player that allows you to
compose music using the following features:

  • Tablature editor
  • Score Viewer
  • Multitrack display
  • Autoscroll while playing
  • Note duration management
  • Various effects (bend, slide, vibrato, hammer-on/pull-off)
  • Support for triplets (5,6,7,9,10,11,12)
  • Repeat open and close
  • Time signature management
  • Tempo management
  • Imports and exports gp3,gp4 and gp5 files

Gentoo-Bug: https://bugs.gentoo.org/360117

Package-Manager: portage-2.3.0

Signed-off-by: Jonathan Scruggs (j.scruggs@gmail.com)

@gentoo-proxy-maint

@gktrk
Copy link
Member

gktrk commented Aug 26, 2016

@gentoo/proxy-maint

default_src_prepare

sed -e "s|../TuxGuitar/lib/swt.jar|$(java-pkg_getjar swt-3.7 swt.jar)|" \
-i TuxGuitar*/build.properties || die "Sed failed to live up to it's name"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/it's/its/

@monsieurp
Copy link
Member

@chewi what do you think? it looks good to me as far as I can tell.

@Amynka Amynka self-assigned this Aug 26, 2016
@Amynka Amynka added the assigned PR successfully assigned to the package maintainer(s). label Aug 26, 2016
@dracwyrm
Copy link
Contributor Author

@gktrk @monsieurp fixed the two "its". :)

A multitrack tablature editor and player that allows you to
compose music using the following features:
- Tablature editor
- Score Viewer
- Multitrack display
- Autoscroll while playing
- Note duration management
- Various effects (bend, slide, vibrato, hammer-on/pull-off)
- Support for triplets (5,6,7,9,10,11,12)
- Repeat open and close
- Time signature management
- Tempo management
- Imports and exports gp3,gp4 and gp5 files

Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=360117

Package-Manager: portage-2.3.0

Signed-off-by: Jonathan Scruggs (j.scruggs@gmail.com)
@chewi
Copy link
Member

chewi commented Aug 29, 2016

Impressive! It's a little unconventional but that appears to be the nature of the beast. I only made one adjustment, moving append-flags out of the loop, otherwise you end up with repeated flags. Just a few things to note.

We normally set the minimal JRE/JDK versions to match the minimum version currently in the tree (1.7) because building with -source 1.5 -target 1.5 makes no guarantee that it'll actually work with 1.5 and we don't trust upstream to get this right.

Not sure if you see this without JAVA_PKG_STRICT set but it says that itext-5 is possibly unneeded. This check isn't always right though so I left it alone.

Some warning about an implicit declaration of ioctl flashed by. Probably not a problem in practise but it's nice to squash errors like that.

Thanks!

@dracwyrm
Copy link
Contributor Author

@chewi Thanks for the tips. I basically left a lot of things program default. It wants a minimum 1.5 java environment. Itext v5.x is needed and is pulled is linked to only when using pdf export. It's under a use flag as there are a lot of depends with itext 5. I'll investigate those warnings that you saw. There appears to be some upstream stuff.

And, I only do unconventional ebuilds. :D coughopenvbdcough

winterheart pushed a commit to winterheart/gentoo that referenced this pull request Sep 4, 2016
A multitrack tablature editor and player that allows you to
compose music using the following features:
- Tablature editor
- Score Viewer
- Multitrack display
- Autoscroll while playing
- Note duration management
- Various effects (bend, slide, vibrato, hammer-on/pull-off)
- Support for triplets (5,6,7,9,10,11,12)
- Repeat open and close
- Time signature management
- Tempo management
- Imports and exports gp3,gp4 and gp5 files

Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=360117

Package-Manager: portage-2.3.0

Signed-off-by: Jonathan Scruggs (j.scruggs@gmail.com)
Closes: gentoo#2149
Signed-off-by: James Le Cuirot <chewi@gentoo.org>
@dracwyrm dracwyrm deleted the tg branch October 1, 2016 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s).
Projects
None yet
5 participants