Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support EAPI 8 in db-use.eclass and qmake-utils.eclass #21539

Closed
wants to merge 2 commits into from
Closed

Support EAPI 8 in db-use.eclass and qmake-utils.eclass #21539

wants to merge 2 commits into from

Conversation

dm0-
Copy link
Contributor

@dm0- dm0- commented Jul 5, 2021

@SoapGentoo SoapGentoo requested a review from Pesa July 5, 2021 16:26
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @dm0-
Areas affected: eclasses
Packages affected: (none)

@gentoo/github

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added the need assignment It was impossible to assign the PR correctly. Please assign it manually. label Jul 5, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-07-05 16:44 UTC
Newest commit scanned: 5f4fd63
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2b40282804/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-07-05 17:09 UTC
Newest commit scanned: 426c9b5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0fa31b9e70/output.html

dm0- added 2 commits July 5, 2021 13:50
@dm0-
db-use.eclass: EAPI 8 support
0f564cd 
This also includes the following cleanups:
  - Drop support for undocumented banned EAPIs.
  - Properly document functions for manpage generation.
  - Make syntax errors fatal.
  - Support cross-compiling.
  - Allow db_findver to accept zero arguments for consistency.
  - Use modern Gentoo bash conventions.

Signed-off-by: David Michael <fedora.dm0@gmail.com>
@dm0-
qmake-utils.eclass: EAPI 8 support
81a5324 
Signed-off-by: David Michael <fedora.dm0@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-07-05 18:04 UTC
Newest commit scanned: 81a5324
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d0f09dd23d/output.html

gentoo-bot pushed a commit that referenced this pull request Jul 9, 2021
@dm0- @Pesa
qmake-utils.eclass: EAPI 8 support
5d58c2e 
#21539

Signed-off-by: David Michael <fedora.dm0@gmail.com>
Signed-off-by: Davide Pesavento <pesa@gentoo.org>
@Pesa
Copy link
Contributor

Pesa commented Jul 9, 2021

Thanks, I've merged the qmake-utils.eclass changes. The other eclass has different maintainers and it's up to them to review/merge the corresponding commit. (you should probably have opened two separate PRs)

@Pesa Pesa removed their request for review July 9, 2021 02:23
@a17r
Copy link
Member

a17r commented Jul 17, 2022

Looks like db-use.eclass was done by #24246 instead.

@a17r a17r closed this Jul 17, 2022
@dm0- dm0- deleted the eclass branch July 17, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
need assignment It was impossible to assign the PR correctly. Please assign it manually.
Projects
None yet
Milestone
No milestone
5 participants
@dm0- @gentoo-bot @gentoo-repo-qa-bot @Pesa @a17r