Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes contextvars deps #21547

Closed
wants to merge 1 commit into from
Closed

removes contextvars deps #21547

wants to merge 1 commit into from

Conversation

inode64
Copy link
Contributor

@inode64 inode64 commented Jul 7, 2021

closes: https://bugs.gentoo.org/799431

Package-Manager: Portage-3.0.20, Repoman-3.0.2
Signed-off-by: INODE64 ffelix@inode64.com

closes: https://bugs.gentoo.org/799431

Package-Manager: Portage-3.0.20, Repoman-3.0.2
Signed-off-by: INODE64 <ffelix@inode64.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @inode64
Areas affected: ebuilds
Packages affected: app-admin/salt

app-admin/salt: @chutz

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jul 7, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-07-07 08:54 UTC
Newest commit scanned: 10a4a79
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2d1bb0d3db/output.html

@myii
Copy link

myii commented Jul 7, 2021

Fixes bug: https://bugs.gentoo.org/799431.

@mattst88
Copy link
Contributor

Signed-off-by: INODE64 ffelix@inode64.com

Please use your real name (that matches with the author of the commit) in the S-o-b tag.

@@ -143,6 +143,9 @@ python_prepare() {
local abc
abc="$("${EPYTHON}" -c 'import collections.abc; print("|".join((c for c in dir(collections.abc) if not c.startswith("_"))))')" || die
find -name '*.py' -type f -print0 | xargs -0 sed -r -e "s:collections\\.(${abc}):collections.abc.\\1:g" -i || die

# removes contextvars, see bug: https://bugs.gentoo.org/799431
sed -i '/^contextvars/d' requirements/base.txt || die
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is doing this enough? I see a few import contextvars in the output of grep contextvars $(qlist app-admin/salt).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it does seem to be enough. Tested locally.

@mattst88 mattst88 requested a review from chutz July 16, 2021 21:04
@mattst88
Copy link
Contributor

Please always prefix your commits with the category/package that you're modifying. E.g. app-admin/salt: Remove contextvars dependency

@inode64 inode64 deleted the salt-stack branch November 7, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
5 participants