Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

games-sports/stormbaancoureur: bump EAPI, fix build #21556

Closed
wants to merge 2 commits into from

Conversation

DarthGandalf
Copy link
Contributor

No description provided.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @DarthGandalf
Areas affected: ebuilds
Packages affected: games-sports/stormbaancoureur

games-sports/stormbaancoureur: @gentoo/games

Linked bugs

Bugs linked: 739386


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 7, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-07-07 22:59 UTC
Newest commit scanned: c96a084
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/059908edab/output.html

Comment on lines 1 to 4
diff --git a/carpettrack.h b/carpettrack.h
index 4bcd7b8..50dfdc9 100644
--- a/carpettrack.h
Copy link
Contributor

@ionenwks ionenwks Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be good to get into the habit of cleaner patches, i.e. strip metadata (like these diff --git and index lines) and at least have some short description, the bgo link (you have one here), and/or upstream links in the patch header as applicable.

For the strip metadata bit, the sed in the devmanual is pretty useful
https://devmanual.gentoo.org/ebuild-writing/misc-files/patches/index.html#clean-patch-howto
Edit: I've made it into a "scrubpatch" command myself -- sometime I use smaller unified context too, especially if patch has no chance to be upstreamed (dead) and it'll just sit in the tree forever using up space on every gentoo users' systems

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Closes: https://bugs.gentoo.org/739386
Package-Manager: Portage-3.0.20, Repoman-3.0.2
Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
Package-Manager: Portage-3.0.20, Repoman-3.0.2
Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-07-08 09:39 UTC
Newest commit scanned: ff396d5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/62da0f3cb0/output.html

Copy link
Contributor

@ionenwks ionenwks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

And thanks for that tc-export CXX too, I tried the old one first but failed on not finding c++, and then seen you've already fixed that 👍

@gentoo-bot gentoo-bot closed this in 2c0adc5 Jul 8, 2021
@DarthGandalf DarthGandalf deleted the storm branch September 8, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants