New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
games-sports/stormbaancoureur: bump EAPI, fix build #21556
Conversation
Pull Request assignmentSubmitter: @DarthGandalf games-sports/stormbaancoureur: @gentoo/games Linked bugsBugs linked: 739386 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2021-07-07 22:59 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
diff --git a/carpettrack.h b/carpettrack.h | ||
index 4bcd7b8..50dfdc9 100644 | ||
--- a/carpettrack.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be good to get into the habit of cleaner patches, i.e. strip metadata (like these diff --git and index lines) and at least have some short description, the bgo link (you have one here), and/or upstream links in the patch header as applicable.
For the strip metadata bit, the sed in the devmanual is pretty useful
https://devmanual.gentoo.org/ebuild-writing/misc-files/patches/index.html#clean-patch-howto
Edit: I've made it into a "scrubpatch" command myself -- sometime I use smaller unified context too, especially if patch has no chance to be upstreamed (dead) and it'll just sit in the tree forever using up space on every gentoo users' systems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Closes: https://bugs.gentoo.org/739386 Package-Manager: Portage-3.0.20, Repoman-3.0.2 Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
Package-Manager: Portage-3.0.20, Repoman-3.0.2 Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
Pull request CI reportReport generated at: 2021-07-08 09:39 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
And thanks for that tc-export CXX
too, I tried the old one first but failed on not finding c++, and then seen you've already fixed that 👍
No description provided.