net-p2p/mldonkey: Patch for C++17 support. #21663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesus P Rey <gentoo@chuso.net> Closes: https://bugs.gentoo.org/790134
Pull Request assignmentSubmitter: @chusopr net-p2p/mldonkey: @chusopr, @gentoo/proxy-maint Linked bugsBugs linked: 790134 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
Pull request CI reportReport generated at: 2021-07-15 19:41 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
bytetype clash between Crypto++ global definition and C++17 one in #790134 by moving their definition to theCryptoPPnamespace.Since their definition is just an alias for
unsigned char, @SoapGentoo recommended in #gentoo-dev-help replacing their use ofbytewithunsigned char. However, that would require a patch modifying ~500 lines of code while this other solution modifies less than 10 lines.Also, more importantly, moving Crypto++ definition of
bytetoCryptoPPnamespace was also the solution adopted upstream: weidai11/cryptopp@00f9818So I decided to follow upstream and this patch just adapts upstream Crypto++'s patch to MLDonkey's bundled version of Crypto++.
Crypto++ also has a wiki page where they discussed this same issue: https://www.cryptopp.com/wiki/Std::byte
I also submitted this same patch to MLDonkey: ygrek/mldonkey#66
But since it seems it's taking the maintainer some time to review it, I'm just already adding it to Portage to fix the compilation error with sys-devel/gcc:11 ASAP.
I've been using net-p2p/mldonkey with this patch for a week with no apparent issues.