media-sound/snapcast, net-libs/libwebsockets & sys-devel/bmake version bumps #21716

jsmolic · 2021-07-19T18:55:13Z

No description provided.

Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>

gentoo-bot · 2021-07-19T18:56:05Z

Pull Request assignment

Submitter: @jsmolic
Areas affected: ebuilds
Packages affected: media-sound/snapcast, net-libs/libwebsockets, sys-devel/bmake

media-sound/snapcast: @jsmolic, @gentoo/proxy-maint
net-libs/libwebsockets: @jkroonza, @jsmolic, ~~luka.perkov[at]sartura.hr~~, @gentoo/proxy-maint
sys-devel/bmake: @jsmolic, @SoapGentoo

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2021-07-19T19:09:49Z

Pull request CI report

Report generated at: 2021-07-19 19:09 UTC
Newest commit scanned: 409c9fa
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3faf0cc6e0/output.html

juippis · 2021-07-20T10:14:40Z

sys-devel/bmake/bmake-20210704.ebuild

+
+EAPI=8
+
+MK_VER=20210330


There seems to be a later version available... but I don't know anything if it's compatible or not. Just FYI.

We don't update MK_VER on every version bump, since it doesn't make much difference on which version we pull in I think it's okay like this

jkroonza

I may be missing something, but these packages don't have tight dependency issues, why are they all in the same PR? Doesn't really matter I guess, just wondering.

jsmolic · 2021-07-21T14:32:42Z

I may be missing something, but these packages don't have tight dependency issues, why are they all in the same PR? Doesn't really matter I guess, just wondering.

They are in the same PR purely out of convenience, since I'm maintaining all packages ;)

juippis

I can't seem to install snapcast

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild  N     ] media-sound/snapcast-0.25.0::gentoo  USE="client expat flac opus server vorbis zeroconf -tremor" 0 KiB

Total: 1 package (1 new), Size of downloads: 0 KiB

Would you like to merge these packages? [Yes/No] y
>>> Verifying ebuild manifests
>>> Emerging (1 of 1) media-sound/snapcast-0.25.0::gentoo
>>> Failed to emerge media-sound/snapcast-0.25.0, Log file:
>>>  '/var/tmp/portage/media-sound/snapcast-0.25.0/temp/build.log'
>>> Jobs: 0 of 1 complete, 1 failed                 Load avg: 0.15, 0.06, 0.23
 * Package:    media-sound/snapcast-0.25.0
 * Repository: gentoo
 * Maintainer: jakov.smolic@sartura.hr proxy-maint@gentoo.org
 * Upstream:   github@badaix.de https://github.com/badaix/snapcast/issues
 * USE:        abi_x86_64 amd64 client elibc_glibc expat flac kernel_linux opus server userland_GNU vorbis zeroconf
 * FEATURES:   network-sandbox preserve-libs sandbox userpriv usersandbox

>>> Unpacking source...
>>> Unpacking snapcast-0.25.0.tar.gz to /var/tmp/portage/media-sound/snapcast-0.25.0/work
>>> Source unpacked in /var/tmp/portage/media-sound/snapcast-0.25.0/work
>>> Preparing source in /var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0 ...
 * Working in BUILD_DIR: "/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0_build"
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0 ...
 * Working in BUILD_DIR: "/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0_build"
cmake -C /var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0_build/gentoo_common_config.cmake -G Ninja -DCMAKE_INSTALL_PREFIX=/usr -DBUILD_CLIENT=yes -DBUILD_WITH_EXPAT=yes -DBUILD_WITH_FLAC=yes -DBUILD_WITH_OPUS=yes -DBUILD_SERVER=yes -DBUILD_STATIC_LIBS=no -DBUILD_TESTS=no -DBUILD_WITH_TREMOR=no -DBUILD_WITH_VORBIS=yes -DBUILD_WITH_AVAHI=yes -DCMAKE_INSTALL_SYSCONFDIR=/etc -DCMAKE_BUILD_TYPE=Gentoo -DCMAKE_TOOLCHAIN_FILE=/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0_build/gentoo_toolchain.cmake  /var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0
loading initial cache file /var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0_build/gentoo_common_config.cmake
-- The CXX compiler identification is GNU 11.1.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/x86_64-pc-linux-gnu-g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- The C compiler identification is GNU 11.1.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/x86_64-pc-linux-gnu-gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Performing Test HAVE_CXX_ATOMICS_WITHOUT_LIB
-- Performing Test HAVE_CXX_ATOMICS_WITHOUT_LIB - Success
-- Found PkgConfig: x86_64-pc-linux-gnu-pkg-config (found version "1.7.4") 
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE  
-- Performing Test HAS_CXX11_STRING_SUPPORT
-- Performing Test HAS_CXX11_STRING_SUPPORT - Success
-- Checking for one of the modules 'alsa'
-- Checking for one of the modules 'libpulse'
-- Checking for one of the modules 'avahi-client'
-- Checking for one of the modules 'soxr'
-- soxr not found
-- Checking for one of the modules 'flac'
-- Checking for one of the modules 'ogg'
-- Checking for one of the modules 'vorbis'
-- Checking for one of the modules 'vorbisenc'
-- Checking for one of the modules 'opus'
-- Checking for one of the modules 'expat'
-- Found Boost: /usr/lib64/cmake/Boost-1.76.0/BoostConfig.cmake (found suitable version "1.76.0", minimum required is "1.70")  
-- <<< Gentoo configuration >>>
Build type      Gentoo
Install path    /usr
Compiler flags:
C               -march=native -O2 -pipe
C++             -march=native -O2 -pipe
Linker flags:
Executable      -Wl,-O1 -Wl,--as-needed
Module          -Wl,-O1 -Wl,--as-needed
Shared          -Wl,-O1 -Wl,--as-needed

-- Configuring done
-- Generating done
-- Build files have been written to: /var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0_build
>>> Source configured.
>>> Compiling source in /var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0 ...
 * Working in BUILD_DIR: "/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0_build"
ninja -v -j1 -l0
[1/51] /usr/bin/x86_64-pc-linux-gnu-g++ -DBOOST_ERROR_CODE_HEADER_ONLY -DHAS_ALSA -DHAS_AVAHI -DHAS_DAEMON -DHAS_EXPAT -DHAS_FLAC -DHAS_OGG -DHAS_OPUS -DHAS_VORBIS -DHAS_VORBIS_ENC -DVERSION=\"0.25.0\" -I/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0 -I/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/include  -march=native -O2 -pipe -Wall -Wextra -pedantic -Wno-unused-function -std=gnu++14 -MD -MT common/CMakeFiles/common.dir/resampler.cpp.o -MF common/CMakeFiles/common.dir/resampler.cpp.o.d -o common/CMakeFiles/common.dir/resampler.cpp.o -c /var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.cpp
FAILED: common/CMakeFiles/common.dir/resampler.cpp.o 
/usr/bin/x86_64-pc-linux-gnu-g++ -DBOOST_ERROR_CODE_HEADER_ONLY -DHAS_ALSA -DHAS_AVAHI -DHAS_DAEMON -DHAS_EXPAT -DHAS_FLAC -DHAS_OGG -DHAS_OPUS -DHAS_VORBIS -DHAS_VORBIS_ENC -DVERSION=\"0.25.0\" -I/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0 -I/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/include  -march=native -O2 -pipe -Wall -Wextra -pedantic -Wno-unused-function -std=gnu++14 -MD -MT common/CMakeFiles/common.dir/resampler.cpp.o -MF common/CMakeFiles/common.dir/resampler.cpp.o.d -o common/CMakeFiles/common.dir/resampler.cpp.o -c /var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.cpp
In file included from /var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/message/pcm_chunk.hpp:23,
                 from /var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.hpp:22,
                 from /var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.cpp:19:
/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/message/message.hpp:119:26: error: 'shared_ptr' in namespace 'std' does not name a template type
  119 | using message_ptr = std::shared_ptr<msg::BaseMessage>;
      |                          ^~~~~~~~~~
/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/message/message.hpp:32:1: note: 'std::shared_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
   31 | #include <vector>
  +++ |+#include <memory>
   32 | 
In file included from /var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.cpp:19:
/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.hpp:38:10: error: 'shared_ptr' in namespace 'std' does not name a template type
   38 |     std::shared_ptr<msg::PcmChunk> resample(std::shared_ptr<msg::PcmChunk> chunk);
      |          ^~~~~~~~~~
/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.hpp:25:1: note: 'std::shared_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
   24 | #include <deque>
  +++ |+#include <memory>
   25 | #include <vector>
/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.hpp:39:10: error: 'shared_ptr' in namespace 'std' does not name a template type
   39 |     std::shared_ptr<msg::PcmChunk> resample(const msg::PcmChunk& chunk);
      |          ^~~~~~~~~~
/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.hpp:39:5: note: 'std::shared_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
   39 |     std::shared_ptr<msg::PcmChunk> resample(const msg::PcmChunk& chunk);
      |     ^~~
/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.cpp:107:32: error: no declaration matches 'std::shared_ptr<msg::PcmChunk> Resampler::resample(const msg::PcmChunk&)'
  107 | std::shared_ptr<msg::PcmChunk> Resampler::resample(const msg::PcmChunk& chunk)
      |                                ^~~~~~~~~
/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.cpp:107:32: note: no functions named 'std::shared_ptr<msg::PcmChunk> Resampler::resample(const msg::PcmChunk&)'
In file included from /var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.cpp:19:
/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.hpp:31:7: note: 'class Resampler' defined here
   31 | class Resampler
      |       ^~~~~~~~~
/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.cpp:194:27: error: no declaration matches 'std::shared_ptr<msg::PcmChunk> Resampler::resample(std::shared_ptr<msg::PcmChunk>)'
  194 | shared_ptr<msg::PcmChunk> Resampler::resample(shared_ptr<msg::PcmChunk> chunk)
      |                           ^~~~~~~~~
/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.cpp:194:27: note: no functions named 'std::shared_ptr<msg::PcmChunk> Resampler::resample(std::shared_ptr<msg::PcmChunk>)'
In file included from /var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.cpp:19:
/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0/common/resampler.hpp:31:7: note: 'class Resampler' defined here
   31 | class Resampler
      |       ^~~~~~~~~
ninja: build stopped: subcommand failed.
 * ERROR: media-sound/snapcast-0.25.0::gentoo failed (compile phase):
 *   ninja -v -j1 -l0 failed
 * 
 * Call stack:
 *     ebuild.sh, line  127:  Called src_compile
 *   environment, line 2124:  Called cmake_src_compile
 *   environment, line  778:  Called cmake_build
 *   environment, line  747:  Called eninja
 *   environment, line 1199:  Called die
 * The specific snippet of code:
 *       "$@" || die "${nonfatal_args[@]}" "${*} failed"
 * 
 * If you need support, post the output of `emerge --info '=media-sound/snapcast-0.25.0::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=media-sound/snapcast-0.25.0::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/media-sound/snapcast-0.25.0/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/media-sound/snapcast-0.25.0/temp/environment'.
 * Working directory: '/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0_build'
 * S: '/var/tmp/portage/media-sound/snapcast-0.25.0/work/snapcast-0.25.0'

tried toggling USE flags here and there, no effect.

* Drop USE=static-libs while at it Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>

* There is no real benefit in having a live ebuild for this package so let's just remove it Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>

jsmolic · 2021-07-28T18:42:10Z

@juippis Oh, I'm sorry but I forgot that I need to include gcc-11 patch in this release, I've pushed again and it should be good now

gentoo-repo-qa-bot · 2021-07-28T18:49:47Z

Pull request CI report

Report generated at: 2021-07-28 18:49 UTC
Newest commit scanned: f2c05d9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d45edfce52/output.html

juippis · 2021-07-29T08:45:09Z

[ERROR] >>> Not all runs were successful.
atom: =net-libs/libwebsockets-4.2.1, USE flags: 'access-log -caps -cgi client -dbus -generic-sessions http-proxy http2 ipv6 lejp -libev libevent -libuv mbedtls peer-limits -server-status -smtp socks5 sqlite3 ssl -threads zip'
atom: =net-libs/libwebsockets-4.2.1, USE flags: 'access-log -caps cgi client dbus generic-sessions http-proxy http2 ipv6 -lejp libev -libevent libuv mbedtls -peer-limits -server-status smtp -socks5 sqlite3 ssl -threads zip'
atom: =net-libs/libwebsockets-4.2.1, USE flags: '-access-log caps cgi client -dbus -generic-sessions http-proxy http2 -ipv6 -lejp libev -libevent -libuv mbedtls peer-limits server-status -smtp socks5 -sqlite3 ssl -threads zip'

There seem to be some common nominators there, but the error seems somehow related to mbedtls:

/mbedtls/mbedtls-x509.c:25:
/var/tmp/portage/net-libs/libwebsockets-4.2.1/work/libwebsockets-4.2.1/lib/tls/mbedtls/mbedtls-x509.c:163:62: error: 'mbedtls_x509_crt' has no member named 'pk'
  163 |                                     mbedtls_pk_get_type(&x509->pk));

(could you confirm, I remember there being some ssl updates lately, maybe my binpkg is broken?)

ionenwks · 2021-07-29T08:57:42Z

There seem to be some common nominators there, but the error seems somehow related to mbedtls:
[...]

I haven't tried this, but if you're using mbedtls-3.0.0 it's likely breaking a lot of things. Upstream even wrote a migration guide from 2.x to 3.0, and given this only came out 22 days ago I imagine packages are behind. If not a regression compared to in-tree with 2.x, it probably shouldn't hold back these PRs.

Edit: actually, just tried current stable libwebsockets-4.2.0 and it fails with mbedtls-3.0.0, no problem with 2.27.0

jsmolic · 2021-07-29T09:43:12Z

No issues for me as well with old mbedtls

juippis · 2021-07-29T10:16:48Z

Should the newest version be restricted in libwebsocket's ebuild, until an upstream patch can be applied?

juippis · 2021-07-29T10:17:33Z

Or should the mbedtls-3.0 be globally masked if it breaks all revdeps? This might require some more checking :I

ionenwks · 2021-07-29T10:22:37Z

Or should the mbedtls-3.0 be globally masked if it breaks all revdeps? This might require some more checking :I

I tried a handful, lighttpd, inspircd, obs-studio, libssh, libssh2, privoxy... all broken with mbedtls-3

juippis · 2021-07-29T10:32:43Z

@ionenwks thanks, I'll package.mask it, open a bugzilla tracker, and merge this PR shortly.

jkroonza · 2021-07-29T10:33:25Z

Perhaps a dual approach is required, mask mbedtls until all ebuilds that depend on mbedtls have been veried and adjusted accordingly, ie, depend on <mbedtls-3.0 or appropriate mbedtls slot :2 vs :3 kind of thing. Can we even install multiple mbedtls versions?

juippis · 2021-07-29T10:45:35Z

That is indeed a tempting idea, but you'd need to update each revdep and revbump them.
So package.mask for now to buy some time, then figure what's the best approach.

Jakov Smolic added 3 commits July 19, 2021 19:29

sys-devel/bmake: Version bump to 20210704

f6f2d32

Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>

sys-devel/bmake: Remove old 20210621

c7087f9

Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>

net-libs/libwebsockets: Version bump to 4.2.1

7066429

Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>

gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Jul 19, 2021

juippis reviewed Jul 20, 2021

View reviewed changes

jkroonza reviewed Jul 21, 2021

View reviewed changes

juippis reviewed Jul 22, 2021

View reviewed changes

Jakov Smolic added 2 commits July 28, 2021 19:38

media-sound/snapcast: Version bump to 0.25.0

b12acf2

* Drop USE=static-libs while at it Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>

media-sound/snapcast: Remove 9999 ebuild

f2c05d9

* There is no real benefit in having a live ebuild for this package so let's just remove it Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>

jsmolic force-pushed the bumps branch from 409c9fa to f2c05d9 Compare July 28, 2021 18:38

gentoo-bot closed this in 8476a0f Jul 29, 2021

jsmolic deleted the bumps branch August 12, 2021 21:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

media-sound/snapcast, net-libs/libwebsockets & sys-devel/bmake version bumps #21716

media-sound/snapcast, net-libs/libwebsockets & sys-devel/bmake version bumps #21716

jsmolic commented Jul 19, 2021

gentoo-bot commented Jul 19, 2021

gentoo-repo-qa-bot commented Jul 19, 2021

juippis Jul 20, 2021

jsmolic Jul 21, 2021

jkroonza left a comment

jsmolic commented Jul 21, 2021

juippis left a comment

jsmolic commented Jul 28, 2021

gentoo-repo-qa-bot commented Jul 28, 2021

juippis commented Jul 29, 2021

ionenwks commented Jul 29, 2021 •

edited

jsmolic commented Jul 29, 2021

juippis commented Jul 29, 2021

juippis commented Jul 29, 2021

ionenwks commented Jul 29, 2021

juippis commented Jul 29, 2021

jkroonza commented Jul 29, 2021

juippis commented Jul 29, 2021


		EAPI=8

		MK_VER=20210330

media-sound/snapcast, net-libs/libwebsockets & sys-devel/bmake version bumps #21716

media-sound/snapcast, net-libs/libwebsockets & sys-devel/bmake version bumps #21716

Conversation

jsmolic commented Jul 19, 2021

gentoo-bot commented Jul 19, 2021

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented Jul 19, 2021

Pull request CI report

juippis Jul 20, 2021

Choose a reason for hiding this comment

jsmolic Jul 21, 2021

Choose a reason for hiding this comment

jkroonza left a comment

Choose a reason for hiding this comment

jsmolic commented Jul 21, 2021

juippis left a comment

Choose a reason for hiding this comment

jsmolic commented Jul 28, 2021

gentoo-repo-qa-bot commented Jul 28, 2021

Pull request CI report

juippis commented Jul 29, 2021

ionenwks commented Jul 29, 2021 • edited

jsmolic commented Jul 29, 2021

juippis commented Jul 29, 2021

juippis commented Jul 29, 2021

ionenwks commented Jul 29, 2021

juippis commented Jul 29, 2021

jkroonza commented Jul 29, 2021

juippis commented Jul 29, 2021

ionenwks commented Jul 29, 2021 •

edited