games-rpg/lure: EAPI8 bump, ebuild improvements #21765
Conversation
Pull Request assignmentSubmitter: @mm1ke games-rpg/lure: @gentoo/games Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2021-07-24 18:04 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2021-07-24 19:29 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
games-rpg/lure/lure-1.1-r1.ebuild
Outdated
| DAT_PV="0.13.1" | ||
| DESCRIPTION="Play as the young peasant named Diermot who has to overthrow an evil sorceress" |
There was a problem hiding this comment.
Trivial but I prefer a blank line before description delimiting the new block.
games-rpg/lure/lure-1.1-r1.ebuild
Outdated
|
|
||
| LICENSE="lure" | ||
| SLOT="0" | ||
| KEYWORDS="~amd64 ~x86" | ||
| LANGS_IUSE="l10n_en l10n_es l10n_de l10n_fr l10n_it" | ||
| IUSE=${LANGS_IUSE} | ||
| IUSE="l10n_de +l10n_en l10n_es l10n_fr l10n_it" | ||
| RESTRICT="mirror" |
There was a problem hiding this comment.
Hmm, seeing this "mirror" made me wonder if it should also have bindist, but reading this license I don't see anything that requires mirror restrictions. All it talks about is about how much we can redistribute this (at least, given license file is provided, which it is in the repos' licenses/ dir).
Unless you noticed something that go against that, just remove the line.
There was a problem hiding this comment.
I've also checked the license but also couldn't find a reason for the RESTRICT=mirror - i've removed it.
games-rpg/lure/lure-1.1-r1.ebuild
Outdated
| local lang name | ||
| for lang in "${MY_L10N[@]//l10n_/}"; do | ||
| [[ "${lang}" == "en" ]] && name="${PN}" || name="${PN}-${lang}" | ||
| mv ${name}/PROTECT.{PDF,pdf} || die |
There was a problem hiding this comment.
You could use newdoc oldname newname in src_install rather than change files in the source directory, should let you get rid of this src_prepare after all.
Alternatively, it's possible to use docompress -x ... to exclude files from compression, but seems more sane to have extensions that aren't all over the place case-wise.
games-rpg/lure/lure-1.1-r1.ebuild
Outdated
| local lang | ||
| local lang name | ||
| for lang in "${MY_L10N[@]//l10n_/}"; do | ||
| [[ "${lang}" == "en" ]] && name="${PN}" || name="${PN}-${lang}" |
There was a problem hiding this comment.
No need for these "", ${PN} and ${lang} won't have spaces. Furthermore, bash tests (aka [[ ]] form) can handle variables with spaces without quoting, so that's never needed either way.
The quotes for MY_L10N are normal to expand the array properly though.
Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Michael Mair-Keimberger <mmk@levelnine.at>
|
@ionenwks |
Pull request CI reportReport generated at: 2021-07-27 17:24 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: Michael Mair-Keimberger mmk@levelnine.at
@ionenwks
Some notes:
notes.txtfile since i don't think it's relevant on linux (and makes it easier for the ebuild ;))src_prepare. However, in case ofPROTECT.PDFthe file would have been compressed which is why i had to rename it. (i guess it's required for doc files that extension are lowercase?) Anyway, I couldn't find any rules about the file extension need to be lowercase which is why i keep it for the other files.