media-libs/sdl-net: EAPI8 bump, minor ebuild improvements #21772
Conversation
Pull Request assignmentSubmitter: @mm1ke media-libs/sdl-net: @gentoo/games Linked bugsBugs linked: 730872 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2021-07-24 20:24 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2021-07-24 22:54 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| DEPEND="${RDEPEND}" | ||
|
|
||
| multilib_src_configure() { | ||
| AS="$(tc-getAS)" ECONF_SOURCE="${S}" econf \ |
There was a problem hiding this comment.
Have you been able to reproduce? It's best not do guessed fixes, can't tell if it really fixed anything.
I tried -native-symlinks (i.e. no "as" command), and I still don't get this. exporting empty AS="" doesn't affect this either so it's unlikely setting this affect anything.
There's also more to it, the tinderbox bug didn't clearly mention it but it used llvm toolchain:
checking for x86_64-pc-linux-gnu-gcc... x86_64-pc-linux-gnu-clang
checking for ld used by x86_64-pc-linux-gnu-clang... ld.lld
ecking for BSD- or MS-compatible name lister (nm)... llvm-nm
checking for x86_64-pc-linux-gnu-objdump... llvm-objdump
checking for x86_64-pc-linux-gnu-ar... llvm-ar
checking for x86_64-pc-linux-gnu-strip... llvm-strip
checking for x86_64-pc-linux-gnu-ranlib... llvm-ranlib
checking how to run the C preprocessor... x86_64-pc-linux-gnu-clang -E
I tried with llvm/clang as well but still nothing. Either this got indirectly fixed (possible considering line 46 of current ./libtool can't fail like this) or there's something up with how the tinderbox setup the llvm toolchain back then.
I'm likely going to close that bug as WORKSFORME instead and check it again only if it resurfaces.
So, you can remove this and the bug reference unless did reproduce.
There was a problem hiding this comment.
(Un)fortunately i couldn't reproduce it either.
What i found out was that after configuring the package, the generated libtool script contains a line with as=AS. However, i couldn't find anywhere in the build that AS was used actually.
I also saw that the llvm toolchain was used and was thinking this bug happens in combination with llvm (thus my initial note that i think i fixed it)..
And with setting AS="$(tc-getAS)" i could fix the libtool file to set it to the correct system variable..
However, since you also couldn't reproduce the problem with the llvm toolchain, I'm happily remove the workaround - and sorry that i haven't explained it more in detail.
| multilib_src_configure() { | ||
| AS="$(tc-getAS)" ECONF_SOURCE="${S}" econf \ | ||
| --disable-gui \ | ||
| $(use_enable static-libs static) |
There was a problem hiding this comment.
Drop this and IUSE="static-libs", I see no reason to support static-libs anymore on this.
EAPI-8's econf will pass --disable-static by default
Since will be only 1 option left, econf call should fit nicely on a single line without \
There was a problem hiding this comment.
Ok, i've also removed it now from the smpeg{,2} ebuilds in the other PR. I've checked the reverse-dependencies and it's not used anywhere.
There was a problem hiding this comment.
Nice, indeed I don't see a need for it on smpeg either (hadn't looked yet).
All these libraries tend to need more attention and if going to revbump into ~arch want to get more done at once, part of why nobody bothered to touch them yet -- but this had to be done sooner or later.
| MY_P="${P/sdl-/SDL_}" | ||
| DESCRIPTION="Simple Direct Media Layer Network Support Library" |
There was a problem hiding this comment.
Prefer a clear cut for the description/homepage block, so I usually have a blank line between these.
| if ! use static-libs ; then | ||
| find "${D}" -type f -name '*.la' -exec rm {} + || die | ||
| fi |
There was a problem hiding this comment.
Make deletion unconditional but use the find statement from the policy guide:
https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0303
| } | ||
|
|
||
| multilib_src_install_all() { | ||
| dodoc CHANGES README |
There was a problem hiding this comment.
CHANGES and README are part of einstalldocs' defaults, so should just use that.
|
|
||
| MY_P="${P/sdl-/SDL_}" | ||
| DESCRIPTION="Simple Direct Media Layer Network Support Library" | ||
| HOMEPAGE="https://www.libsdl.org/projects/SDL_net/index.html" |
There was a problem hiding this comment.
Seem can drop the index.html bit.
mm1ke
force-pushed
the
sdln-lmalFnnA
branch
2 times, most recently
from
90e409d
to
31254b8
Compare
Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Michael Mair-Keimberger <mmk@levelnine.at> Bug: https://bugs.gentoo.org/730872
Pull request CI reportReport generated at: 2021-07-28 17:44 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2021-07-28 18:19 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: Michael Mair-Keimberger mmk@levelnine.at
I've looked into https://bugs.gentoo.org/730872 too and i think the problem was because it called
ASdirectly. Please have a look. In theconfig.statusfile it now uses the correct tool, but i couldn't see anywhere in the logs that it was used.