games-puzzle/tanglet: bump to 1.6.1.1 fixing compilation with >=qt*-5.14 #21800
Conversation
Pull Request assignmentSubmitter: @kobboi games-puzzle/tanglet: @gentoo/games Linked bugsBugs linked: 804570 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2021-07-26 21:24 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
I kind of wanted to suggest migration to cmake, but seems the CMakeLists.txt is QT6-only. I guess Qt5 is on its last legs for this package.
More importantly, is this really running as expected for you? I just get a "Unable to read dice from file". Or at least with a blank state, maybe you have old settings that let it work for you?
From a quick look at strace it tried:
29748 access("/usr/bin/data/en/dice", F_OK) = -1 ENOENT (No such file or directory)
29748 access("/usr/share/data/en/dice", F_OK) = -1 ENOENT (No such file or directory)
29748 access("/usr/Resources/data/en/dice", F_OK) = -1 ENOENT (No such file or directory)
29748 openat(AT_FDCWD, "tanglet:en/dice", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
These paths don't look right, it should be at /usr/share/tanglet/data/en/dice
|
@ionenwks Thanks for your feedback. I tested with ebuild, not emerge. I will re-investigate and post an update |
Signed-off-by: Christophe Lermytte <gentoo@lermytte.be> Bug: https://bugs.gentoo.org/804570 Closes: gentoo#21800
|
Pretty sure that what happened is: I tested with the patch disabled, then enabled it when I noticed the /usr/local paths and did not properly re-test. I force-pushed a new commit that addresses your points and this time the game is working properly. Note that at the time the compilation (unknown version) was still OK, I remember the game also not working, with similar error messages as you describe above. Likely the patch never worked, or at least not with 1.5.3 (maybe it did with 1.5.2, as per the filename) |
Pull request CI reportReport generated at: 2021-07-27 17:39 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| " | ||
| RDEPEND="${DEPEND}" | ||
|
|
||
| PATCHES=( "${FILESDIR}"/${PN}-1.6.1.1-gentoo.patch ) |
There was a problem hiding this comment.
Ah, hadn't looked at this patch yet, I do see how this happened.
And to be honest, that old -gentoo.patch was all kind of garbage, it also doesn't respect ${EPREFIX}.
You can remove the modified patch and this line entirely, there's a better option.
Edit: patch was likely from back when we were using /usr/games and a hack to make this work, but when migrated back to normal /usr the patch was edited rather than removed.
| PATCHES=( "${FILESDIR}"/${PN}-1.6.1.1-gentoo.patch ) | ||
|
|
||
| src_configure() { | ||
| eqmake5 tanglet.pro |
There was a problem hiding this comment.
| eqmake5 tanglet.pro | |
| eqmake5 PREFIX="${EPREFIX}/usr" tanglet.pro |
Dropping the patch since
- the first part does not respect ${EPREFIX} and can be replaced with an
environment variable in the ebuild
- the other parts are obsolete
Signed-off-by: Christophe Lermytte <gentoo@lermytte.be>
Bug: https://bugs.gentoo.org/804570
Closes: gentoo#21800
|
Force-pushed the above suggestion and adapted the commit message accordingly. |
Pull request CI reportReport generated at: 2021-07-28 22:04 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
No new dependencies found in the binary. Existing patch still applies.