Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-misc/rpick: Add 0.8.5 and drop 0.8.2 #21803

Closed
wants to merge 2 commits into from

Conversation

bowlofeggs
Copy link
Contributor

No description provided.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @bowlofeggs
Areas affected: ebuilds
Packages affected: app-misc/rpick

app-misc/rpick: @bowlofeggs, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Jul 27, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-07-27 02:09 UTC
Newest commit scanned: 22bee02
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b0c00c6f29/output.html

app-misc/rpick/rpick-0.8.5.ebuild Outdated Show resolved Hide resolved
app-misc/rpick/rpick-0.8.5.ebuild Outdated Show resolved Hide resolved
app-misc/rpick/rpick-0.8.5.ebuild Outdated Show resolved Hide resolved
@bowlofeggs
Copy link
Contributor Author

Hello @ionenwks, thanks for the review. I will apply this patch and force push:

--- a/app-misc/rpick/rpick-0.8.5.ebuild
+++ b/app-misc/rpick/rpick-0.8.5.ebuild
@@ -1,7 +1,7 @@
 # Copyright 2019-2021 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
-EAPI=7
+EAPI=8
 
 CRATES="
        aho-corasick-0.7.18
@@ -124,12 +124,10 @@ LICENSE="GPL-3 Apache-2.0 Apache-2.0-with-LLVM-exceptions BSD BSD-2 Boost-1.0 CC
 SLOT="0"
 KEYWORDS="~amd64 ~ppc64 ~x86"
 
-# Rust packages ignore CFLAGS and LDFLAGS so let's silence the QA warnings
 QA_FLAGS_IGNORED="usr/bin/rpick"
 
 src_install() {
        cargo_src_install
 
-       local DOCS=( CHANGELOG.md README.md )
-       einstalldocs
+       dodoc CHANGELOG.md README.md
 }

Package-Manager: Portage-3.0.20, Repoman-3.0.2
Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
Package-Manager: Portage-3.0.20, Repoman-3.0.2
Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
Copy link
Contributor

@ionenwks ionenwks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks perfect, I'll push it in a bit.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-07-30 21:19 UTC
Newest commit scanned: 1b223ee
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a943fdfb18/output.html

@bowlofeggs bowlofeggs deleted the rpick-0.8.5 branch August 1, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants