Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

games-fps/freedoom-data: Requires games-util/deutex[png] #21819

Closed
wants to merge 5 commits into from
Closed

games-fps/freedoom-data: Requires games-util/deutex[png] #21819

wants to merge 5 commits into from

Conversation

vilhelmgray
Copy link
Contributor

This adds the png USE flag requirement to the games-util/deutex dependency for games-fps/freedoom-data and games-fps/freedm-data; the games-util/deutex is updated to default enable PNG support.

In addition, I noticed the games-fps/freedoom and games-fps/freedm ebuilds were missing games-fps/chocolate-doom as an optional source port, so I've updated them accordingly.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @vilhelmgray
Areas affected: ebuilds
Packages affected: games-fps/freedm, games-fps/freedm-data, games-fps/freedoom, games-fps/freedoom-data, games-util/deutex

games-fps/freedm: @vilhelmgray, @gentoo/proxy-maint, @gentoo/games
games-fps/freedm-data: @vilhelmgray, @gentoo/proxy-maint, @gentoo/games
games-fps/freedoom: @vilhelmgray, @gentoo/proxy-maint, @gentoo/games
games-fps/freedoom-data: @vilhelmgray, @gentoo/proxy-maint, @gentoo/games
games-util/deutex: @vilhelmgray, @gentoo/proxy-maint, @gentoo/games

Linked bugs

Bugs linked: 804882

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 29, 2021
@ionenwks
Copy link
Contributor

The bug mentions that it still built/installed without it, meaning there could be people with a broken install.

Normally do a revbump to force reinstall in these cases.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-07-29 05:59 UTC
Newest commit scanned: 433c5a3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3b0c95e988/output.html

@vilhelmgray
Copy link
Contributor Author

Good point, I'll update these to be revbumps.

@vilhelmgray vilhelmgray force-pushed the freedoom-data_fix_deutex_deps branch from 433c5a3 to 3b0482e Compare July 29, 2021 06:23
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-07-29 06:34 UTC
Newest commit scanned: 3b0482e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0bcaa8cc02/output.html

ionenwks
ionenwks reviewed Jul 29, 2021
View reviewed changes
Copy link
Contributor

@ionenwks ionenwks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exposed a small issue.

Also, I assume don't mean to keep the old revision? Small fix like this is okay to drop in same commit (aka rename / git mv).

games-fps/freedm-data/freedm-data-0.12.1-r1.ebuild Outdated Show resolved Hide resolved
games-fps/freedoom-data/freedoom-data-0.12.1-r1.ebuild Outdated Show resolved Hide resolved
@vilhelmgray
games-fps/freedoom-data: Add png USE requirement for deutex dependency
835b6fd 
Closes: https://bugs.gentoo.org/804882
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
@vilhelmgray
games-fps/freedm-data: Add png USE requirement for deutex dependency
7cf735f 
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
@vilhelmgray
games-util/deutex: Default enable PNG support
575cd04 
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
@vilhelmgray
games-fps/freedoom: Add chocolate-doom as optional source port
c020411 
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
@vilhelmgray
games-fps/freedm: Add chocolate-doom as optional source port
88d7afa 
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
@vilhelmgray vilhelmgray force-pushed the freedoom-data_fix_deutex_deps branch from 3b0482e to 88d7afa Compare July 29, 2021 09:56
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-07-29 10:09 UTC
Newest commit scanned: 88d7afa
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2c2c87a796/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ionenwks ionenwks ionenwks approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@vilhelmgray @gentoo-bot @ionenwks @gentoo-repo-qa-bot