Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-fs/udev: enable musl #21862

Closed
wants to merge 1 commit into from
Closed

sys-fs/udev: enable musl #21862

wants to merge 1 commit into from

Conversation

SoapGentoo
Copy link
Member

Signed-off-by: David Seifert soap@gentoo.org

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @SoapGentoo
Areas affected: ebuilds, profiles
Packages affected: sys-fs/udev

sys-fs/udev: @gentoo/udev

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Aug 2, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-08-02 14:09 UTC
Newest commit scanned: 0bb2105
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d3064d8a7a/output.html

floppym
floppym reviewed Aug 2, 2021
View reviewed changes
sys-fs/udev/udev-249-r2.ebuild Outdated
@@ -22,6 +22,9 @@ else
KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~s390 ~sparc ~x86"
fi

SRC_URI+="
elibc_musl? ( https://dev.gentoo.org/~soap/distfiles/${P}-musl-patches.tar.xz )"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment indicating where these patches came from?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how different it to the tmpfiles patchset.
looking at tar archive yours it a bit smaller.
# http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-core/systemd/systemd
# check SRC_URI_MUSL in systemd_${PV}.bb file for exact list of musl patches
^ I just extract those patches without much filtering.

@SoapGentoo SoapGentoo force-pushed the musl-systemd-udev branch 2 times, most recently from 36aaef7 to 8c725fc Compare August 2, 2021 16:37
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-08-02 17:09 UTC
Newest commit scanned: 8c725fc
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a235c703b0/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-08-02 18:04 UTC
Newest commit scanned: 0d8e50c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2e5c45591d/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-08-03 10:39 UTC
Newest commit scanned: 3ce270b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5966289c56/output.html

gyakovlev
gyakovlev approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@gyakovlev gyakovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add app-text/tree as test depend and good to go.
passes all test on ppc64-be-musl, except 2 disk related irrelevant tests.

@SoapGentoo
sys-fs/udev: enable musl
b5f9a5c 
Signed-off-by: David Seifert <soap@gentoo.org>
@gentoo-bot gentoo-bot closed this in eb6b84e Aug 3, 2021
@SoapGentoo SoapGentoo deleted the musl-systemd-udev branch August 3, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyakovlev gyakovlev gyakovlev approved these changes

@floppym floppym floppym approved these changes

@thesamesam thesamesam thesamesam approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
6 participants
@SoapGentoo @gentoo-bot @gentoo-repo-qa-bot @gyakovlev @floppym @thesamesam