Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-im/telegram-desktop: Bug fixes and version bump #21871

Closed
wants to merge 4 commits into from

Conversation

mid-kid
Copy link
Contributor

@mid-kid mid-kid commented Aug 3, 2021

Closes: https://bugs.gentoo.org/806292
See-also: https://bugs.archlinux.org/task/71541
Thanks-to: Ilia Durov <ildurrx@mail.ru>
Signed-off-by: Esteve Varela Colominas <esteve.varela@gmail.com>
…e being

Bug: https://bugs.gentoo.org/803233
Signed-off-by: Esteve Varela Colominas <esteve.varela@gmail.com>
Signed-off-by: Esteve Varela Colominas <esteve.varela@gmail.com>
inb4 upstream releases a "General system stability improvements to
enhance the user's experience." bump.

Signed-off-by: Esteve Varela Colominas <esteve.varela@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mid-kid
Areas affected: ebuilds
Packages affected: net-im/telegram-desktop

net-im/telegram-desktop: @mid-kid, @gentoo/proxy-maint

Linked bugs

Bugs linked: 803233, 806292


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Aug 3, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-08-03 21:39 UTC
Newest commit scanned: ddd6b07
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f94e3c22a5/output.html

@gentoo-bot gentoo-bot closed this in 189af5c Aug 4, 2021
@gyakovlev
Copy link
Member

gyakovlev commented Aug 4, 2021

thanks, merged.

I had to revbump 2.8.11, because both changes you have introduced required a revbump.
changing RDEPEND generally requires revbump, except some edge cases.
patching runtime behavior requires revbump, no exceptions, or very very very rarely you can omit revbump, this change is not that case.

and any users who already updated to stable ( via https://bugs.gentoo.org/802537) will get a patched up -r1 version now.

@mid-kid
Copy link
Contributor Author

mid-kid commented Aug 4, 2021

You're right, I forgot. Sorry.

@gyakovlev
Copy link
Member

no problem at all =) that's my job too to catch those things. you do heavy lifting, I catch policy stuff, seems like good collaboration ;-)

@mid-kid
Copy link
Contributor Author

mid-kid commented Aug 4, 2021

@gyakovlev I re-read the commits and I noticed I messed up with usex. Can you merge this commit real quick? mid-kid@0846f5a

@gyakovlev
Copy link
Member

merged, sorry for missing it.
I always hated negative logic in those options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants