sci-electronics/kicad: Fixup ebuild to support opencascade-7.5.2 #21918
Conversation
Pull Request assignmentSubmitter: @zpuskas sci-electronics/kicad: @zpuskas, @gentoo/proxy-maint Linked bugsBugs linked: 800944 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
Pull request CI reportReport generated at: 2021-08-08 18:44 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| if has_version ">=sci-libs/opencascade-7.5"; then | ||
| if has_version ">=sci-libs/opencascade-7.5.2"; then |
There was a problem hiding this comment.
These >= don't mean much if it only works for "this" version. You can use ~ (aka ~cat/pkg-7.5.2, same for 7.5.1 below) to say "this version at any revision", and then limit in *DEPEND or else it will break again next opencascade version rather than say "don't upgrade opencascade yet".
For RDEPEND, given all slots are fine, feels kind of bad but guess can do:
occ? ( <sci-libs/opencascade-7.5.3:=[vtk(+)] ) (not <= to ensure it pickups potential 7.5.2 revisions)
Given there's a := operator and >=7.5.2[occ] couldn't build, a revbump shouldn't be necessary despite RDEPEND change.
I'd like to think there's a better way to do this, but haven't explored opencascade/kicad stuff to suggest anything, for now it's better than nothing anyway.
There was a problem hiding this comment.
Thanks for the suggestions. I'll apply them and revert back to -r1.
OpenCascade has this issue, I'm not sure if any of the packages using it found a better solution to this so far.
OpenCascade currently is hard to handle and some version pinning is neccessary. This diff updates ebuild to support all current OpenCasade versions in Portage. Closes: https://bugs.gentoo.org/800944 Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Zoltan Puskas <zoltan@sinustrom.info>
Pull request CI reportReport generated at: 2021-08-09 03:39 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2021-08-09 03:49 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
No description provided.