Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media-sound/pulseaudio: fixes unifdef failure #22013

Closed
wants to merge 1 commit into from
Closed

media-sound/pulseaudio: fixes unifdef failure #22013

wants to merge 1 commit into from

Conversation

pinkflames
Copy link
Contributor

This bug got introduced because no one tests system-wide setups.
This is still untested but according to Ionen unifdef call should now
fail if there wasn't anything to modify which is exactly what we want.

Thanks-to: Ionen Wolkens ionen@gentoo.org
Signed-off-by: Niklāvs Koļesņikovs 89q1r14hd@relay.firefox.com

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Aug 17, 2021
@pinkflames
media-sound/pulseaudio: fixes unifdef failure
ca9e274 
This bug got introduced because no one tests system-wide setups.
This is still untested but according to Ionen unifdef call should now
fail if there wasn't anything to modify which is exactly what we want.

Closes: https://bugs.gentoo.org/805488
Thanks-to: Ionen Wolkens <ionen@gentoo.org>
Signed-off-by: Niklāvs Koļesņikovs <89q1r14hd@relay.firefox.com>
@pinkflames pinkflames changed the title media-sound/pulseaudio: fixes unifdef failure media-sound/pulseaudio: fixes unifdef failure [please reassign] Aug 17, 2021
@gentoo-bot gentoo-bot changed the title media-sound/pulseaudio: fixes unifdef failure [please reassign] media-sound/pulseaudio: fixes unifdef failure Aug 17, 2021
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @pinkflames
Areas affected: ebuilds
Packages affected: media-sound/pulseaudio

media-sound/pulseaudio: @gentoo/gnome

Linked bugs

Bugs linked: 805488

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Aug 17, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-08-17 14:25 UTC
Newest commit scanned: e911ce0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9e4eb243f8/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-08-17 14:49 UTC
Newest commit scanned: ca9e274
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/131fdcadc7/output.html

@thesamesam thesamesam self-requested a review August 18, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam Awaiting requested review from thesamesam

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
3 participants
@pinkflames @gentoo-bot @gentoo-repo-qa-bot