sys-apps/busybox: Disable standalone shell mode with USE=make-symlinks #22038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Busybox has by default enabled CONFIG_FEATURE_PREFER_APPLETS and CONFIG_FEATURE_SH_STANDALONE which means it will bypass all PATH lookups and use its builtin applets. This is problematic as we sometimes might want to use the original program instead of Busybox applets, so let's disable those two options when building with USE=make-symlinks. This also enables users to disable a builtin by deleting the corresponding symlink. Closes: https://bugs.gentoo.org/729184 Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
Pull Request assignmentSubmitter: @jsmolic sys-apps/busybox: @gentoo/embedded Linked bugsBugs linked: 729184 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2021-08-19 17:34 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and CONFIG_FEATURE_SH_STANDALONE which means it will
bypass all PATH lookups and use its builtin applets.
This is problematic as we sometimes might want to use the
original program instead of Busybox applets, so let's
disable those two options when building with USE=make-symlinks.
This also enables users to disable a builtin by deleting the
corresponding symlink.
Closes: https://bugs.gentoo.org/729184