New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
media-video/rav1e: add USE=static-libs #22089
Conversation
Pull Request assignmentSubmitter: @Hello71 media-video/rav1e: @lu-zero, @gentoo/video Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. Missing GCO sign-offPlease read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
a0569cb
to
1a6b216
Compare
Pull request CI reportReport generated at: 2021-08-24 11:39 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2021-08-24 11:49 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
1a6b216
to
f179ee6
Compare
Pull request CI reportReport generated at: 2021-08-24 12:34 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
f179ee6
to
60a8fab
Compare
What's the purpose of supporting static libs in the first place? |
i don't know that much about rust, but i think possibly the ABI is not stable? anyways, i don't want to break someone's spacebar heating if the USE flag is easy to add. i don't feel strongly about the option, just don't want them installed by default. |
Would you mind changing to just never install static libs, then I'll merge? Thanks! |
Closes: https://bugs.gentoo.org/730526 Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
60a8fab
to
1319f08
Compare
Pull request CI reportReport generated at: 2021-09-12 14:00 UTC New issues caused by PR: There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Just in case of unexpected consumers. See: #22089 Signed-off-by: Sam James <sam@gentoo.org>
Thanks! |
tested libheif[rav1e], libavif[rav1e] still working