Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-video/rav1e: add USE=static-libs #22089

Closed
wants to merge 1 commit into from

Conversation

Hello71
Copy link
Contributor

@Hello71 Hello71 commented Aug 24, 2021

tested libheif[rav1e], libavif[rav1e] still working

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @Hello71
Areas affected: ebuilds
Packages affected: media-video/rav1e

media-video/rav1e: @lu-zero, @gentoo/video

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Aug 24, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-08-24 11:39 UTC
Newest commit scanned: a0569cb
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/255da75069/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-08-24 11:49 UTC
Newest commit scanned: 1a6b216
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7247420e88/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-08-24 12:34 UTC
Newest commit scanned: f179ee6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/24abc02882/output.html

@mgorny
Copy link
Member

mgorny commented Sep 11, 2021

What's the purpose of supporting static libs in the first place?

@Hello71
Copy link
Contributor Author

Hello71 commented Sep 11, 2021

i don't know that much about rust, but i think possibly the ABI is not stable? anyways, i don't want to break someone's spacebar heating if the USE flag is easy to add. i don't feel strongly about the option, just don't want them installed by default.

@thesamesam
Copy link
Member

Would you mind changing to just never install static libs, then I'll merge? Thanks!

Closes: https://bugs.gentoo.org/730526
Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-09-12 14:00 UTC
Newest commit scanned: 1319f08
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/9243f5c045/output.html#global

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9243f5c045/output.html

gentoo-bot pushed a commit that referenced this pull request Sep 12, 2021
Just in case of unexpected consumers.

See: #22089
Signed-off-by: Sam James <sam@gentoo.org>
@thesamesam
Copy link
Member

Thanks!

@Hello71 Hello71 deleted the rav1e-no-static-libs branch December 15, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
5 participants