sci-libs/rocRAND: bump version to 4.3.0 #22113
Conversation
Pull Request assignmentSubmitter: @littlewu2508 sci-libs/rocRAND: @gentoo/sci, @candrews, @justxi Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
from the CI resport |
| SLOT="0/$(ver_cut 1-2)" | ||
| IUSE="benchmark test" | ||
|
|
||
| RDEPEND="=dev-util/hip-$(ver_cut 1-2)*" |
| -DCMAKE_SKIP_RPATH="ON" | ||
| -D__skip_rocmclang="ON" ## fix cmake-3.21 configuration issue caused by officialy support programming language "HIP" | ||
| ) | ||
| [ -n "${AMDGPU_TARGETS}" ] && mycmakeargs+=( -DAMDGPU_TARGETS="${AMDGPU_TARGETS}" ) |
There was a problem hiding this comment.
Update this similar as rocBLAS.
littlewu2508
force-pushed
the
sci-libs/rocRAND
branch
from
1fe62be
to
210c64a
Compare
|
|
||
| RDEPEND="dev-util/hip:${SLOT}" | ||
| DEPEND="${RDEPEND} | ||
| dev-util/rocm-cmake:${SLOT}" |
There was a problem hiding this comment.
@littlewu2508 please move rocm-cmake into BDEPEND
| SLOT="0/$(ver_cut 1-2)" | ||
| IUSE="benchmark test" | ||
|
|
||
| RDEPEND="dev-util/hip:${SLOT}" |
There was a problem hiding this comment.
I have no idea about ROC but I’ve noticed you’re exposing sub slots in lots of these packages (which is fine!) but remember to use := if you need to be rebuilt when the subslot changes.
A revbump is needed to add := if it’s already in tree.
There was a problem hiding this comment.
You are right, Sam. This should be rebuilt when dev-util/hip goes to a new sub-SLOT. In addition they have to be at the same sub-SLOT to function.
The dependency should be dev-util/hip:${SLOT}=.
There was a problem hiding this comment.
I don't think we should use := to revbump when subslot changes. dev-util/hip:${SLOT}= does not work with subslots. Also, :${SLOT} is already enough to ensure version consistency. Any user who upgrade hip but not rocRAND will meet slot conflict and then they know the reverse dependency have to upgrade or unmerge.
|
|
||
| if use benchmark; then | ||
| cd "${BUILD_DIR}"/benchmark | ||
| chrpath -d benchmark_rocrand_* |
There was a problem hiding this comment.
Missing || die on external commands (both cd and chrpath)
There was a problem hiding this comment.
@littlewu2508 please put || die after cd.
littlewu2508
force-pushed
the
sci-libs/rocRAND
branch
3 times, most recently
from
9222ae2
to
01b42f1
Compare
Pull request CI reportReport generated at: 2021-10-09 13:35 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
littlewu2508
force-pushed
the
sci-libs/rocRAND
branch
from
01b42f1
to
ebd041b
Compare
Enable benchmark and test. Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
Pull request CI reportReport generated at: 2021-10-10 15:30 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Enable benchmark and test.
Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: Yiyang Wu xgreenlandforwyy@gmail.com