app-arch/lz4: Add USE=lib-only #22168
Conversation
* Add lib-only flag which provides a minimal lz4 build with only library and without other binaries. This is useful in e.g. embedded or stripped down systems where one might want just the core functionality of liblz4. Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>
Pull Request assignmentSubmitter: @jsmolic app-arch/lz4: @mgorny, @amadio Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
| @@ -14,7 +14,7 @@ LICENSE="BSD-2 GPL-2" | |||
| # https://abi-laboratory.pro/tracker/timeline/lz4/ | |||
| SLOT="0/r132" | |||
| KEYWORDS="~alpha amd64 arm arm64 hppa ~ia64 ~m68k ~mips ppc ppc64 ~riscv ~s390 sparc x86 ~amd64-linux ~x86-linux ~ppc-macos ~x64-macos ~sparc-solaris ~sparc64-solaris ~x64-solaris ~x86-solaris" | |||
| IUSE="static-libs" | |||
| IUSE="lib-only static-libs" | |||
There was a problem hiding this comment.
I'd consider IUSE=minimal instead, as that's an existing global use flag used by many packages.
There was a problem hiding this comment.
I'm okay with minimal as well
Pull request CI reportReport generated at: 2021-08-31 11:29 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
What's the end goal here? Given that lz4 executable is 80k in size (+3k for manpage), this sounds like a serious overkill. For a start, it's going to mean that we're going to have to verify all revdeps for whether they're using the library or the executable, and force This really looks like a case for |
|
@mgorny Yeah, I'm aware about the size, although it still matters when you're fighting for every kb but I admit difference is small, that's why I was unsure and wanted to hear your opinion. I do have a use case for this, but at the same time I don't want to create more unnecessary work given that difference here is very small and I don't know if we want to go through updating all revdeps just for this. In any case if you're not up for accepting this I can opt for a different solution and avoid changing |
|
Yes, I'd prefer not having this in |
|
Okay, thanks for your input |
Changelog:
Fixed a bug that could leak IPAM entries when a network was removed (#22034).
Fixed a bug that could cause the rootless network namespace to not be cleaned up on if an error occurred during setup resulting in errors relating to a missing resolv.conf being displayed (#22168).
Fixed a bug where Podman would use rootless network namespace logic for nested containers (#22218).
Fixed a bug where writing to volumes on a Mac could result in EACCESS failures when using the :z or :Z volume mount options on a directory with read only files (#19852)
Fixed a bug in the Compat List endpoint for Networks which could result in a server crash due to concurrent writes to a map (#22330).
Signed-off-by: Rahil Bhimjiani <me@rahil.rocks>
From: #36302
Signed-off-by: Zac Medico <zmedico@gentoo.org>
with only library and without other binaries. This is
useful in e.g. embedded or stripped down systems where
one might want just the core functionality of liblz4.
Signed-off-by: Jakov Smolić jsmolic@gentoo.org