Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

games-emulation/desmume: fix build with clang #22331

Closed
wants to merge 1 commit into from
Closed

games-emulation/desmume: fix build with clang #22331

wants to merge 1 commit into from

Conversation

DarthGandalf
Copy link
Contributor

Closes: https://bugs.gentoo.org/739144
Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: Alexey Sokolov alexey+gentoo@asokolov.org

@DarthGandalf
games-emulation/desmume: fix build with clang
b1c1178 
Closes: https://bugs.gentoo.org/739144
Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @DarthGandalf
Areas affected: ebuilds
Packages affected: games-emulation/desmume

games-emulation/desmume: @gentoo/games

Linked bugs

Bugs linked: 739144

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 18, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-09-18 23:59 UTC
Newest commit scanned: b1c1178
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fbe8c8b0a2/output.html

ionenwks
ionenwks approved these changes Sep 19, 2021
View reviewed changes
Copy link
Contributor

@ionenwks ionenwks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's something I should've fixed myself back then but forgot about.

Albeit it'll be fixed whenever do another snapshot from TASEmulators/desmume@92cb90f

Upstream was semi-inactive for a while, and think I'll wait a bit longer before considering another snapshot -- so your simpler fix will do :)

@DarthGandalf DarthGandalf deleted the desmume branch January 13, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ionenwks ionenwks ionenwks approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@DarthGandalf @gentoo-bot @gentoo-repo-qa-bot @ionenwks