app-editors/remarkable: new package #22341

madmartin · 2021-09-20T16:45:41Z

remarkable is a full featured markdown editor, supporting
the github markdown dialect

Closes: https://bugs.gentoo.org/616208
Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: Martin Dummer martin.dummer@gmx.net

gentoo-bot · 2021-09-20T16:48:06Z

Pull Request assignment

Submitter: @madmartin
Areas affected: ebuilds
Packages affected: app-editors/remarkable

app-editors/remarkable: @gentoo/proxy-maint (new package)

Linked bugs

Bugs linked: 616208

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2021-09-20T16:59:54Z

Pull request CI report

Report generated at: 2021-09-20 16:59 UTC
Newest commit scanned: da1076e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/aa4c854952/output.html

telans · 2021-09-24T08:06:41Z

app-editors/remarkable/remarkable-1.9.0_pre20210320.ebuild

+	')"
+RDEPEND="${DEPEND}"
+BDEPEND=""
+PATCHES=( "${FILESDIR}"/disable-spellcheck.patch )


Why what? please ask more specific

Why include a disable spellcheck patch?

I suppose looking further it may be because that package doesn't exist. If you wanted to you could add it here! Up to you of course

Yes, that's the reason. pygtkspellcheck has no gentoo package, and I am not motivated to do this yet.

Please add PN and preferably some PV to the patch name so it's identifiable.
https://devmanual.gentoo.org/ebuild-writing/misc-files/patches/index.html#file-naming

juippis · 2021-10-15T13:24:07Z

app-editors/remarkable/remarkable-1.9.0_pre20210320.ebuild

+PYTHON_COMPAT=( python3_{8..10} )
+inherit desktop gnome2-utils python-single-r1
+
+DESCRIPTION="a fully featured markdown editor, supports github markdown dialect"


Suggested change

DESCRIPTION="a fully featured markdown editor, supports github markdown dialect"

DESCRIPTION="A fully featured markdown editor, supports github markdown dialect"

or

Suggested change

DESCRIPTION="a fully featured markdown editor, supports github markdown dialect"

DESCRIPTION="Fully featured markdown editor, supports github markdown dialect"

I choose the second variant, saves 2 bytes!

juippis · 2021-10-15T13:27:43Z

app-editors/remarkable/remarkable-1.9.0_pre20210320.ebuild

+SRC_URI="https://github.com/jamiemcg/remarkable/archive/${GIT_COMMIT}.tar.gz -> ${P}.tar.gz"
+S="${WORKDIR}/Remarkable-${GIT_COMMIT}"
+
+LICENSE="MIT"


Please re-check this, e.g. https://github.com/jamiemcg/Remarkable/blob/master/remarkable/findBar.py is GPL-2+. And https://github.com/jamiemcg/Remarkable/blob/master/remarkable/undobuffer.py is LGPL-2.1+

Looks like it needs LICENSE="BSD-2 GPL-2+ LGPL-2.1+ MIT"

juippis · 2021-10-15T13:28:08Z

app-editors/remarkable/remarkable-1.9.0_pre20210320.ebuild

+DEPEND="
+	${PYTHON_DEPS}
+	net-libs/webkit-gtk
+	$(python_gen_cond_dep '
+		dev-python/beautifulsoup4[${PYTHON_USEDEP}]
+		dev-python/pycairo[${PYTHON_USEDEP}]
+		dev-python/pygobject[${PYTHON_USEDEP}]
+		dev-python/markdown[${PYTHON_USEDEP}]
+	')"
+RDEPEND="${DEPEND}"


# remarkable Traceback (most recent call last): File "/usr/lib/python-exec/python3.8/remarkable", line 65, in <module> import remarkable File "/usr/lib/python3.8/site-packages/remarkable/__init__.py", line 30, in <module> from remarkable import RemarkableWindow File "/usr/lib/python3.8/site-packages/remarkable/RemarkableWindow.py", line 26, in <module> gi.require_version('GtkSource', '3.0') File "/usr/lib/python3.8/site-packages/gi/__init__.py", line 126, in require_version raise ValueError('Namespace %s not available' % namespace) ValueError: Namespace GtkSource not available

Hmmm.... I am a bit clueless here. Maybe the use-flags of webkit-gtk are different at your side? My installation has
[I] net-libs/webkit-gtk ... Installed versions: 2.32.4(4/37)^t(23:24:37 10/05/21)(X egl geolocation gstreamer introspection jpeg2k jumbo-build libnotify opengl seccomp spell -aqua -examples -gamepad -gles2-only -gnome-keyring -gtk-doc -systemd -test -wayland)

You'll have to depend on x11-libs/gtksourceview:3.0 (:3.0 specifically). And you need the [introspection] from it.
Oh you also need to depend on gtk+-3[introspection] and webkit-gtk[introspection] too.

@juippis Thanks for pointing that out!
All changes done.

juippis · 2021-10-15T13:28:15Z

app-editors/remarkable/remarkable-1.9.0_pre20210320.ebuild

+		dev-python/markdown[${PYTHON_USEDEP}]
+	')"
+RDEPEND="${DEPEND}"
+BDEPEND=""


Can be removed.

juippis · 2021-10-15T13:29:03Z

app-editors/remarkable/remarkable-1.9.0_pre20210320.ebuild

+	')"
+RDEPEND="${DEPEND}"
+BDEPEND=""
+PATCHES=( "${FILESDIR}"/disable-spellcheck.patch )


Please add PN and preferably some PV to the patch name so it's identifiable.
https://devmanual.gentoo.org/ebuild-writing/misc-files/patches/index.html#file-naming

juippis · 2021-10-15T13:31:57Z

app-editors/remarkable/remarkable-1.9.0_pre20210320.ebuild

+	ewarn "Known issues:"
+	ewarn "- export to HTML/PDF does not work (\"wkhtmltopdf\" not packetized/will never be)"
+	ewarn "- spellchecking is disabled (would need python module \"pygtkspellcheck\")"


Maybe these could be shipped with a readme file, via https://devmanual.gentoo.org/eclass-reference/readme.gentoo-r1.eclass/index.html?

What's wrong with shipping wkhtmltopdf?

wkhtmltopdf declares himself to be almost dead and depends on qtwebkit....

I will take a look at readme.gentoo-r1.eclass for sure.

gentoo-repo-qa-bot · 2021-10-16T13:11:09Z

Pull request CI report

Report generated at: 2021-10-16 13:11 UTC
Newest commit scanned: 527cda3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/bda843990a/output.html

juippis

Few things to improve, but looking really good! Got the program to launch and it works.

juippis · 2021-10-25T10:19:41Z

app-editors/remarkable/remarkable-1.9.0_pre20210320.ebuild

+DEPEND="
+	${PYTHON_DEPS}
+	net-libs/webkit-gtk
+	$(python_gen_cond_dep '
+		dev-python/beautifulsoup4[${PYTHON_USEDEP}]
+		dev-python/pycairo[${PYTHON_USEDEP}]
+		dev-python/pygobject[${PYTHON_USEDEP}]
+		dev-python/markdown[${PYTHON_USEDEP}]
+	')"
+RDEPEND="${DEPEND}"


You'll have to depend on x11-libs/gtksourceview:3.0 (:3.0 specifically). And you need the [introspection] from it.
Oh you also need to depend on gtk+-3[introspection] and webkit-gtk[introspection] too.

juippis · 2021-10-25T10:21:37Z

app-editors/remarkable/files/README.gentoo

@@ -0,0 +1,10 @@
+
+Known issues:


Suggested change

Known issues:

Known Gentoo-related issues:

juippis · 2021-10-25T10:22:18Z

app-editors/remarkable/files/README.gentoo

+  "wkhtmltopdf" which is not packetized for gentoo and most probably will
+  never be - it depends on deprecated Qt WebKit)
+- spellchecking is disabled (would need python module pygtkspellcheck which)
+  is also not packetized for gentoo yet)


Suggested change

is also not packetized for gentoo yet)

is also not packaged for gentoo yet)

I'm not a native English speaker but "packetized" doesn't sound like any word to me :P

I'm also not a native english speaker, but the two dictionaries I ask know "to packetize"... which is more or less the same meaning as "to package". If you think "packaged" sounds nicer I'll change that.

Yes please.

juippis · 2021-10-25T10:22:38Z

app-editors/remarkable/remarkable-1.9.0_pre20210320.ebuild

+inherit desktop gnome2-utils python-single-r1 readme.gentoo-r1
+
+DESCRIPTION="Fully featured markdown editor, supports github markdown dialect"
+HOMEPAGE="http://remarkableapp.github.io/ https://github.com/jamiemcg/remarkable"


Suggested change

HOMEPAGE="http://remarkableapp.github.io/ https://github.com/jamiemcg/remarkable"

HOMEPAGE="https://remarkableapp.github.io/ https://github.com/jamiemcg/remarkable"

remarkable is a full featured markdown editor, supporting the github markdown dialect Closes: https://bugs.gentoo.org/616208 Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Martin Dummer <martin.dummer@gmx.net>

gentoo-repo-qa-bot · 2021-10-27T21:31:29Z

Pull request CI report

Report generated at: 2021-10-27 21:31 UTC
Newest commit scanned: 1c2752e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0e02e0c6ee/output.html

juippis

Thanks a lot!

madmartin force-pushed the remarkable branch from 56d5a6a to da1076e Compare September 20, 2021 16:48

telans reviewed Sep 24, 2021

View reviewed changes

juippis reviewed Oct 15, 2021

View reviewed changes

madmartin force-pushed the remarkable branch from da1076e to 527cda3 Compare October 16, 2021 12:56

madmartin requested a review from juippis October 16, 2021 12:57

juippis reviewed Oct 25, 2021

View reviewed changes

app-editors/remarkable: new package

1c2752e

remarkable is a full featured markdown editor, supporting the github markdown dialect Closes: https://bugs.gentoo.org/616208 Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Martin Dummer <martin.dummer@gmx.net>

madmartin force-pushed the remarkable branch from 527cda3 to 1c2752e Compare October 27, 2021 21:18

juippis approved these changes Oct 31, 2021

View reviewed changes

gentoo-bot closed this in 32c96d5 Oct 31, 2021

madmartin deleted the remarkable branch November 16, 2021 06:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

app-editors/remarkable: new package #22341

app-editors/remarkable: new package #22341

madmartin commented Sep 20, 2021 •

edited

gentoo-bot commented Sep 20, 2021

gentoo-repo-qa-bot commented Sep 20, 2021

telans Sep 24, 2021

madmartin Sep 24, 2021

telans Sep 25, 2021

telans Sep 25, 2021

madmartin Sep 25, 2021

juippis Oct 15, 2021

juippis Oct 15, 2021

madmartin Oct 15, 2021

juippis Oct 15, 2021

madmartin Oct 15, 2021

juippis Oct 15, 2021

madmartin Oct 16, 2021 •

edited

juippis Oct 25, 2021 •

edited

madmartin Oct 27, 2021

juippis Oct 15, 2021

juippis Oct 15, 2021

juippis Oct 15, 2021

madmartin Oct 16, 2021

gentoo-repo-qa-bot commented Oct 16, 2021

juippis left a comment

juippis Oct 25, 2021 •

edited

juippis Oct 25, 2021

juippis Oct 25, 2021

madmartin Oct 25, 2021

juippis Oct 26, 2021

juippis Oct 25, 2021

gentoo-repo-qa-bot commented Oct 27, 2021

juippis left a comment

	DESCRIPTION="a fully featured markdown editor, supports github markdown dialect"
	DESCRIPTION="A fully featured markdown editor, supports github markdown dialect"

	DESCRIPTION="a fully featured markdown editor, supports github markdown dialect"
	DESCRIPTION="Fully featured markdown editor, supports github markdown dialect"

	is also not packetized for gentoo yet)
	is also not packaged for gentoo yet)

	HOMEPAGE="http://remarkableapp.github.io/ https://github.com/jamiemcg/remarkable"
	HOMEPAGE="https://remarkableapp.github.io/ https://github.com/jamiemcg/remarkable"

app-editors/remarkable: new package #22341

app-editors/remarkable: new package #22341

Conversation

madmartin commented Sep 20, 2021 • edited

gentoo-bot commented Sep 20, 2021

Pull Request assignment

Linked bugs

New packages

gentoo-repo-qa-bot commented Sep 20, 2021

Pull request CI report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

madmartin Oct 16, 2021 • edited

Choose a reason for hiding this comment

juippis Oct 25, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Oct 16, 2021

Pull request CI report

juippis left a comment

Choose a reason for hiding this comment

juippis Oct 25, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Oct 27, 2021

Pull request CI report

juippis left a comment

Choose a reason for hiding this comment

madmartin commented Sep 20, 2021 •

edited

madmartin Oct 16, 2021 •

edited

juippis Oct 25, 2021 •

edited

juippis Oct 25, 2021 •

edited