app-emulation/lxd: Add keepdir

[ulziibuyan]

Add keepdir function to create /var/log/lxd directory. Fixes bug https://bugs.gentoo.org/817287

Signed-off-by: Uzi Erdenebileg lzijbuan@gmail.com

[gentoo-bot]

Pull Request assignment

Submitter: @ulziibuyan
Areas affected: ebuilds
Packages affected: app-emulation/lxd

app-emulation/lxd: @juippis, @gentoo/virtualization

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2021-10-10 02:45 UTC
Newest commit scanned: 8108086
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/94046c3aec/output.html

[juippis]

Few things. First of all we shouldn't use keepdir like this, this should be handled by init.d and .service files due to individual configurations.

For openrc the logging is by default disabled, which enables everyone to easily determine the log dir before enabling it, but I see it's enabled by default in the systemd service files.

Then nitpicks:
https://projects.gentoo.org/qa/policy-guide/ebuild-format.html#pg0101 you shouldn't try to use spaces to indent :P

But it is an important and fast temporary fix, so let's merge. Gonna update the init/service files for the next release. Thank you!

[ulziibuyan]

@juippis thank you for the informative review. Would you be nice and add hacktoberfest-accepted label to this pull request? Although minor, I think it should still be counted as a contribution :)

[juippis]

Hey, didn't know this was a thing again. I remember we had this last year. I can't seem to enable the label right now, but asked our GitHub team to resolve it:
https://bugs.gentoo.org/817782

Hopefully it gets solved before October is over (for our other contributions) but AFAIK you can still deem the rewards afterwards!