net-vpn/openfortivpn: Version bump 1.17.0 #22560
Conversation
Scantlight
commented
Oct 12, 2021
•
Scantlight
commented
- Bumping version to 1.17.0 and 1.17.1
- Added systemd USE flag that will guide the installation of systemd service template file
Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Petru Ciobanu <scantlight@gmail.com>
Pull Request assignmentSubmitter: @Scantlight net-vpn/openfortivpn: @gentoo/proxy-maint (maintainer needed) Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
maintainer-needed
Pull request CI reportReport generated at: 2021-10-12 01:30 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Petru Ciobanu <scantlight@gmail.com>
|
Hi. I've updated the PR and added another commit got the version 1.17.1 ... please feel free to comment if this PR is or is not in line with the guidelines, I'm more than willing to change it for the best. Thanks. |
Pull request CI reportReport generated at: 2021-10-13 06:15 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
…t file Those variables needs to be replaced with real location that contains the expected executable and configuration. Bug: https://bugs.gentoo.org/766357 Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Petru Ciobanu <scantlight@gmail.com>
In case the system doesn't use systemd, this should disable the installation of the service unit. Bug: https://bugs.gentoo.org/766357 Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Petru Ciobanu <scantlight@gmail.com>
Pull request CI reportReport generated at: 2021-10-17 21:15 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| DEPEND=" | ||
| net-dialup/ppp | ||
| dev-libs/openssl:0= | ||
| systemd? ( sys-apps/systemd ) |
There was a problem hiding this comment.
Nearly there, but we install systemd unit files unconditionally.
There was a problem hiding this comment.
Thanks Sam.
If I understand it correctly, I just need to drop this last commit since the systemd flag will not be required. Correct me if I'm wrong.
Also, I can't explain why I did not noticed the policy-guide documentation until now. Thanks for the link, I will try to give it a read and use it as reference for the future.
There was a problem hiding this comment.
No problem, thanks a lot for your quick reply and your first contribution! 😃
|
I'm super duper happy to have my first commit merged to Gentoo! I'm looking forward to do more! Thanks Sam! |
|
@Scantlight Very happy to have you! Just give me a shout if you need anything 💯! |
