Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sci-libs/rocSPARSE: remove incomplete test suites which fail #22564

Closed
wants to merge 1 commit into from
Closed

sci-libs/rocSPARSE: remove incomplete test suites which fail #22564

wants to merge 1 commit into from

Conversation

littlewu2508
Copy link
Contributor

test_csricsv.yaml does not have function parameters for testing
csricsv, so template function csricsv will be uninstantiated, which
causes gtest to FAIL it. This is also the cause for csrilusv.
Since these two yaml does not contain actual tests, just remove them at
this time.

Package-Manager: Portage-3.0.22, Repoman-3.0.3
Signed-off-by: Yiyang Wu xgreenlandforwyy@gmail.com

@littlewu2508
sci-libs/rocSPARSE: remove incomplete test suites which fail
13395e1 
test_csricsv.yaml does not have function parameters for testing
csricsv, so template function csricsv will be uninstantiated, which
causes gtest to FAIL it. This is also the cause for csrilusv.
Since these two yaml does not contain actual tests, just remove them at
this time.

Package-Manager: Portage-3.0.22, Repoman-3.0.3
Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @littlewu2508
Areas affected: ebuilds
Packages affected: sci-libs/rocSPARSE

sci-libs/rocSPARSE: @gentoo/sci, @candrews, @justxi

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Oct 12, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-10-12 12:20 UTC
Newest commit scanned: 13395e1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3fbb512f54/output.html

@heroxbd
Copy link
Contributor

heroxbd commented Oct 12, 2021

test_csricsv.yaml does not have function parameters for testing csricsv, so template function csricsv will be uninstantiated, which causes gtest to FAIL it. This is also the cause for csrilusv. Since these two yaml does not contain actual tests, just remove them at this time.

Package-Manager: Portage-3.0.22, Repoman-3.0.3 Signed-off-by: Yiyang Wu xgreenlandforwyy@gmail.com

I think it a good idea to forward this issue upstream, too.

@heroxbd heroxbd added the work in progress The PR is not yet ready to be merged. label Nov 3, 2021
@littlewu2508
Copy link
Contributor Author

The fix is incorrect. The root cause is misplaced matrix data file during src_prepare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. work in progress The PR is not yet ready to be merged.
Projects
None yet
Milestone
No milestone
4 participants
@littlewu2508 @gentoo-bot @gentoo-repo-qa-bot @heroxbd